Make UserScript non-copyable.

extensions/common/user_script_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
 #include "base/pickle.h"
 #include "extensions/common/user_script.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace extensions {
 
 static const int kAllSchemes =
     URLPattern::SCHEME_HTTP |
     URLPattern::SCHEME_HTTPS |
     URLPattern::SCHEME_FILE |
     URLPattern::SCHEME_FTP |
     URLPattern::SCHEME_CHROMEUI;
 
 TEST(ExtensionUserScriptTest, Glob_HostString) {
-  UserScript script;
+  ScriptMetadata script;
   script.add_glob("*mail.google.com*");
   script.add_glob("*mail.yahoo.com*");
   script.add_glob("*mail.msn.com*");
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.google.com")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.google.com/foo")));
   EXPECT_TRUE(script.MatchesURL(GURL("https://mail.google.com/foo")));
   EXPECT_TRUE(script.MatchesURL(GURL("ftp://mail.google.com/foo")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://woo.mail.google.com/foo")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.yahoo.com/bar")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.msn.com/baz")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://www.hotmail.com")));
 
   script.add_exclude_glob("*foo*");
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.google.com")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://mail.google.com/foo")));
 }
 
 TEST(ExtensionUserScriptTest, Glob_TrailingSlash) {
-  UserScript script;
+  ScriptMetadata script;
   script.add_glob("*mail.google.com/");
   // GURL normalizes the URL to have a trailing "/"
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.google.com")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.google.com/")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://mail.google.com/foo")));
 }
 
 TEST(ExtensionUserScriptTest, Glob_TrailingSlashStar) {
-  UserScript script;
+  ScriptMetadata script;
   script.add_glob("http://mail.google.com/*");
   // GURL normalizes the URL to have a trailing "/"
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.google.com")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://mail.google.com/foo")));
   EXPECT_FALSE(script.MatchesURL(GURL("https://mail.google.com/foo")));
 }
 
 TEST(ExtensionUserScriptTest, Glob_Star) {
-  UserScript script;
+  ScriptMetadata script;
   script.add_glob("*");
   EXPECT_TRUE(script.MatchesURL(GURL("http://foo.com/bar")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://hot.com/dog")));
   EXPECT_TRUE(script.MatchesURL(GURL("https://hot.com/dog")));
   EXPECT_TRUE(script.MatchesURL(GURL("file:///foo/bar")));
   EXPECT_TRUE(script.MatchesURL(GURL("file://localhost/foo/bar")));
 }
 
 TEST(ExtensionUserScriptTest, Glob_StringAnywhere) {
-  UserScript script;
+  ScriptMetadata script;
   script.add_glob("*foo*");
   EXPECT_TRUE(script.MatchesURL(GURL("http://foo.com/bar")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://baz.org/foo/bar")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://baz.org")));
 }
 
 TEST(ExtensionUserScriptTest, UrlPattern) {
   URLPattern pattern(kAllSchemes);
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern.Parse("http://*/foo*"));
 
-  UserScript script;
+  ScriptMetadata script;
   script.add_url_pattern(pattern);
   EXPECT_TRUE(script.MatchesURL(GURL("http://monkey.com/foobar")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://monkey.com/hotdog")));
 
   // NOTE: URLPattern is tested more extensively in url_pattern_unittest.cc.
 }
 
 TEST(ExtensionUserScriptTest, ExcludeUrlPattern) {
-  UserScript script;
+  ScriptMetadata script;
 
   URLPattern pattern(kAllSchemes);
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern.Parse("http://*.nytimes.com/*"));
   script.add_url_pattern(pattern);
 
   URLPattern exclude(kAllSchemes);
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, exclude.Parse("*://*/*business*"));
   script.add_exclude_url_pattern(exclude);
 
   EXPECT_TRUE(script.MatchesURL(GURL("http://www.nytimes.com/health")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://www.nytimes.com/business")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://business.nytimes.com")));
 }
 
 TEST(ExtensionUserScriptTest, UrlPatternAndIncludeGlobs) {
-  UserScript script;
+  ScriptMetadata script;
 
   URLPattern pattern(kAllSchemes);
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern.Parse("http://*.nytimes.com/*"));
   script.add_url_pattern(pattern);
 
   script.add_glob("*nytimes.com/???s/*");
 
   EXPECT_TRUE(script.MatchesURL(GURL("http://www.nytimes.com/arts/1.html")));
   EXPECT_TRUE(script.MatchesURL(GURL("http://www.nytimes.com/jobs/1.html")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://www.nytimes.com/sports/1.html")));
 }
 
 TEST(ExtensionUserScriptTest, UrlPatternAndExcludeGlobs) {
-  UserScript script;
+  ScriptMetadata script;
 
   URLPattern pattern(kAllSchemes);
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern.Parse("http://*.nytimes.com/*"));
   script.add_url_pattern(pattern);
 
   script.add_exclude_glob("*science*");
 
   EXPECT_TRUE(script.MatchesURL(GURL("http://www.nytimes.com")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://science.nytimes.com")));
   EXPECT_FALSE(script.MatchesURL(GURL("http://www.nytimes.com/science")));
 }
 
 TEST(ExtensionUserScriptTest, UrlPatternGlobInteraction) {
   // If there are both, match intersection(union(globs), union(urlpatterns)).
-  UserScript script;
+  ScriptMetadata script;
 
   URLPattern pattern(kAllSchemes);
   ASSERT_EQ(URLPattern::PARSE_SUCCESS,
             pattern.Parse("http://www.google.com/*"));
   script.add_url_pattern(pattern);
 
   script.add_glob("*bar*");
 
   // No match, because it doesn't match the glob.
   EXPECT_FALSE(script.MatchesURL(GURL("http://www.google.com/foo")));
@@ skipping 18 matching lines @@
 TEST(ExtensionUserScriptTest, Pickle) {
   URLPattern pattern1(kAllSchemes);
   URLPattern pattern2(kAllSchemes);
   URLPattern exclude1(kAllSchemes);
   URLPattern exclude2(kAllSchemes);
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern1.Parse("http://*/foo*"));
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern2.Parse("http://bar/baz*"));
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, exclude1.Parse("*://*/*bar"));
   ASSERT_EQ(URLPattern::PARSE_SUCCESS, exclude2.Parse("https://*/*"));
 
-  UserScript script1;
-  script1.js_scripts().push_back(UserScript::File(
-      base::FilePath(FILE_PATH_LITERAL("c:\\foo\\")),
-      base::FilePath(FILE_PATH_LITERAL("foo.user.js")),
-      GURL("chrome-extension://abc/foo.user.js")));
-  script1.css_scripts().push_back(UserScript::File(
-      base::FilePath(FILE_PATH_LITERAL("c:\\foo\\")),
-      base::FilePath(FILE_PATH_LITERAL("foo.user.css")),
-      GURL("chrome-extension://abc/foo.user.css")));
-  script1.css_scripts().push_back(UserScript::File(
-      base::FilePath(FILE_PATH_LITERAL("c:\\foo\\")),
-      base::FilePath(FILE_PATH_LITERAL("foo2.user.css")),
-      GURL("chrome-extension://abc/foo2.user.css")));
+  ScriptMetadata script1;
+  script1.js_scripts().push_back(base::WrapUnique(
+      new UserScriptFileInfo(base::FilePath(FILE_PATH_LITERAL("c:\\foo\\")),
+                             base::FilePath(FILE_PATH_LITERAL("foo.user.js")),
+                             GURL("chrome-extension://abc/foo.user.js"))));
+  script1.css_scripts().push_back(base::WrapUnique(
+      new UserScriptFileInfo(base::FilePath(FILE_PATH_LITERAL("c:\\foo\\")),
+                             base::FilePath(FILE_PATH_LITERAL("foo.user.css")),
+                             GURL("chrome-extension://abc/foo.user.css"))));
+  script1.css_scripts().push_back(base::WrapUnique(
+      new UserScriptFileInfo(base::FilePath(FILE_PATH_LITERAL("c:\\foo\\")),
+                             base::FilePath(FILE_PATH_LITERAL("foo2.user.css")),
+                             GURL("chrome-extension://abc/foo2.user.css"))));
   script1.set_run_location(UserScript::DOCUMENT_START);
 
   script1.add_url_pattern(pattern1);
   script1.add_url_pattern(pattern2);
   script1.add_exclude_url_pattern(exclude1);
   script1.add_exclude_url_pattern(exclude2);
 
   const int64_t kId = 12;
   script1.set_id(kId);
   const std::string kExtensionId = "foo";
   HostID id(HostID::EXTENSIONS, kExtensionId);
   script1.set_host_id(id);
 
   base::Pickle pickle;
-  script1.Pickle(&pickle);
+  // Pickle script.
+  {
+    // Only browser/ side (BrowserUserScript) and renderer/ side
+    // (RendererUserScript) implementation of user script is (de)serializable,
+    // ScriptMetadata is common/, so pickle it manually.
+    static_cast<UserScriptInfo*>(&script1)->Pickle(&pickle);
+    static_cast<UserScriptFiles<UserScriptFileInfo>*>(&script1)->PickleFiles(
+        &pickle);
+  }
 
   base::PickleIterator iter(pickle);
-  UserScript script2;
-  script2.Unpickle(pickle, &iter);
+  ScriptMetadata script2;
+  {
+    // Same as Pickle step above, unpickle this manually.
+    static_cast<UserScriptInfo*>(&script2)->Unpickle(pickle, &iter);
+    static_cast<UserScriptFiles<UserScriptFileInfo>*>(&script2)->UnpickleFiles(
+        pickle, &iter);
+  }
 
   EXPECT_EQ(1U, script2.js_scripts().size());
-  EXPECT_EQ(script1.js_scripts()[0].url(), script2.js_scripts()[0].url());
+  EXPECT_EQ(script1.js_scripts()[0]->url(), script2.js_scripts()[0]->url());
 
   EXPECT_EQ(2U, script2.css_scripts().size());
   for (size_t i = 0; i < script2.js_scripts().size(); ++i) {
-    EXPECT_EQ(script1.css_scripts()[i].url(), script2.css_scripts()[i].url());
+    EXPECT_EQ(script1.css_scripts()[i]->url(), script2.css_scripts()[i]->url());
   }
 
   ASSERT_EQ(script1.globs().size(), script2.globs().size());
   for (size_t i = 0; i < script1.globs().size(); ++i) {
     EXPECT_EQ(script1.globs()[i], script2.globs()[i]);
   }
 
   ASSERT_EQ(script1.url_patterns(), script2.url_patterns());
   ASSERT_EQ(script1.exclude_url_patterns(), script2.exclude_url_patterns());
 
   EXPECT_EQ(kExtensionId, script2.extension_id());
   EXPECT_EQ(kId, script2.id());
 }
 
 TEST(ExtensionUserScriptTest, Defaults) {
-  UserScript script;
+  ScriptMetadata script;
   ASSERT_EQ(UserScript::DOCUMENT_IDLE, script.run_location());
 }
 
 }  // namespace extensions