Make UserScript non-copyable.

chrome/browser/extensions/extension_user_script_loader_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_user_script_loader.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <string>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/location.h"
+#include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/test/test_browser_thread.h"
+#include "extensions/browser/browser_user_script.h"
 #include "extensions/common/host_id.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 using extensions::URLPatternSet;
 
 namespace {
 
 static void AddPattern(URLPatternSet* extent, const std::string& pattern) {
   int schemes = URLPattern::SCHEME_ALL;
@@ skipping 83 matching lines @@
     "// \n"
     "// @othergarbage\n"
     "// @include *mail.yahoo.com*\r\n"
     "// @include  \t *mail.msn.com*\n" // extra spaces after "@include" OK
     "//@include not-recognized\n" // must have one space after "//"
     "// ==/UserScript==  trailing garbage\n"
     "\n"
     "\n"
     "alert('hoo!');\n");
 
-  UserScript script;
+  BrowserUserScript script;
   EXPECT_TRUE(ExtensionUserScriptLoader::ParseMetadataHeader(text, &script));
   ASSERT_EQ(3U, script.globs().size());
   EXPECT_EQ("*mail.google.com*", script.globs()[0]);
   EXPECT_EQ("*mail.yahoo.com*", script.globs()[1]);
   EXPECT_EQ("*mail.msn.com*", script.globs()[2]);
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, Parse2) {
   const std::string text("default to @include *");
 
-  UserScript script;
+  BrowserUserScript script;
   EXPECT_TRUE(ExtensionUserScriptLoader::ParseMetadataHeader(text, &script));
   ASSERT_EQ(1U, script.globs().size());
   EXPECT_EQ("*", script.globs()[0]);
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, Parse3) {
   const std::string text(
     "// ==UserScript==\n"
     "// @include *foo*\n"
     "// ==/UserScript=="); // no trailing newline
 
-  UserScript script;
+  BrowserUserScript script;
   ExtensionUserScriptLoader::ParseMetadataHeader(text, &script);
   ASSERT_EQ(1U, script.globs().size());
   EXPECT_EQ("*foo*", script.globs()[0]);
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, Parse4) {
   const std::string text(
     "// ==UserScript==\n"
     "// @match http://*.mail.google.com/*\n"
     "// @match  \t http://mail.yahoo.com/*\n"
     "// ==/UserScript==\n");
 
   URLPatternSet expected_patterns;
   AddPattern(&expected_patterns, "http://*.mail.google.com/*");
   AddPattern(&expected_patterns, "http://mail.yahoo.com/*");
 
-  UserScript script;
+  BrowserUserScript script;
   EXPECT_TRUE(ExtensionUserScriptLoader::ParseMetadataHeader(text, &script));
   EXPECT_EQ(0U, script.globs().size());
   EXPECT_EQ(expected_patterns, script.url_patterns());
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, Parse5) {
   const std::string text(
     "// ==UserScript==\n"
     "// @match http://*mail.google.com/*\n"
     "// ==/UserScript==\n");
 
   // Invalid @match value.
-  UserScript script;
+  BrowserUserScript script;
   EXPECT_FALSE(ExtensionUserScriptLoader::ParseMetadataHeader(text, &script));
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, Parse6) {
   const std::string text(
     "// ==UserScript==\n"
     "// @include http://*.mail.google.com/*\n"
     "// @match  \t http://mail.yahoo.com/*\n"
     "// ==/UserScript==\n");
 
   // Allowed to match @include and @match.
-  UserScript script;
+  BrowserUserScript script;
   EXPECT_TRUE(ExtensionUserScriptLoader::ParseMetadataHeader(text, &script));
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, Parse7) {
   // Greasemonkey allows there to be any leading text before the comment marker.
   const std::string text(
     "// ==UserScript==\n"
     "adsasdfasf// @name hello\n"
     "  // @description\twiggity woo\n"
     "\t// @match  \t http://mail.yahoo.com/*\n"
     "// ==/UserScript==\n");
 
-  UserScript script;
+  BrowserUserScript script;
   EXPECT_TRUE(ExtensionUserScriptLoader::ParseMetadataHeader(text, &script));
   ASSERT_EQ("hello", script.name());
   ASSERT_EQ("wiggity woo", script.description());
   ASSERT_EQ(1U, script.url_patterns().patterns().size());
   EXPECT_EQ("http://mail.yahoo.com/*",
             script.url_patterns().begin()->GetAsString());
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, Parse8) {
   const std::string text(
     "// ==UserScript==\n"
     "// @name myscript\n"
     "// @match http://www.google.com/*\n"
     "// @exclude_match http://www.google.com/foo*\n"
     "// ==/UserScript==\n");
 
-  UserScript script;
+  BrowserUserScript script;
   EXPECT_TRUE(ExtensionUserScriptLoader::ParseMetadataHeader(text, &script));
   ASSERT_EQ("myscript", script.name());
   ASSERT_EQ(1U, script.url_patterns().patterns().size());
   EXPECT_EQ("http://www.google.com/*",
             script.url_patterns().begin()->GetAsString());
   ASSERT_EQ(1U, script.exclude_url_patterns().patterns().size());
   EXPECT_EQ("http://www.google.com/foo*",
             script.exclude_url_patterns().begin()->GetAsString());
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, SkipBOMAtTheBeginning) {
   base::FilePath path = temp_dir_.path().AppendASCII("script.user.js");
   const std::string content("\xEF\xBB\xBF alert('hello');");
   size_t written = base::WriteFile(path, content.c_str(), content.size());
   ASSERT_EQ(written, content.size());
 
-  UserScript user_script;
-  user_script.js_scripts().push_back(
-      UserScript::File(temp_dir_.path(), path.BaseName(), GURL()));
+  std::unique_ptr<BrowserUserScript> user_script(new BrowserUserScript);
+  std::unique_ptr<BrowserScriptFile> file1(
+      new BrowserScriptFile(temp_dir_.path(), path.BaseName(), GURL()));
+  user_script->js_scripts().push_back(std::move(file1));
 
-  UserScriptList user_scripts;
-  user_scripts.push_back(user_script);
+  BrowserUserScriptList user_scripts;
+  user_scripts.push_back(std::move(user_script));
 
   TestingProfile profile;
   ExtensionUserScriptLoader loader(
       &profile,
       HostID(),
       true /* listen_for_extension_system_loaded */);
   loader.LoadScriptsForTest(&user_scripts);
 
   EXPECT_EQ(content.substr(3),
-            user_scripts[0].js_scripts()[0].GetContent().as_string());
+            user_scripts[0]->js_scripts()[0]->GetContent().as_string());
 }
 
 TEST_F(ExtensionUserScriptLoaderTest, LeaveBOMNotAtTheBeginning) {
   base::FilePath path = temp_dir_.path().AppendASCII("script.user.js");
   const std::string content("alert('here's a BOOM: \xEF\xBB\xBF');");
   size_t written = base::WriteFile(path, content.c_str(), content.size());
   ASSERT_EQ(written, content.size());
 
-  UserScript user_script;
-  user_script.js_scripts().push_back(UserScript::File(
-      temp_dir_.path(), path.BaseName(), GURL()));
+  std::unique_ptr<BrowserUserScript> user_script(new BrowserUserScript);
+  user_script->js_scripts().push_back(base::WrapUnique(
+      new BrowserScriptFile(temp_dir_.path(), path.BaseName(), GURL())));
 
-  UserScriptList user_scripts;
-  user_scripts.push_back(user_script);
+  BrowserUserScriptList user_scripts;
+  user_scripts.push_back(std::move(user_script));
 
   TestingProfile profile;
   ExtensionUserScriptLoader loader(
       &profile,
       HostID(),
       true /* listen_for_extension_system_loaded */);
   loader.LoadScriptsForTest(&user_scripts);
 
-  EXPECT_EQ(content, user_scripts[0].js_scripts()[0].GetContent().as_string());
+  EXPECT_EQ(content,
+            user_scripts[0]->js_scripts()[0]->GetContent().as_string());
 }
 
 }  // namespace extensions