Merge CPDFSDK_FormActionHandler into CPDFSDK_ActionHandler

fpdfsdk/fsdk_actionhandler.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/fsdk_actionhandler.h"
 
 #include <set>
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
 #include "core/fpdfdoc/include/cpdf_formfield.h"
 #include "core/fpdfdoc/include/cpdf_interform.h"
 #include "fpdfsdk/include/fsdk_define.h"
 #include "fpdfsdk/include/fsdk_mgr.h"
 #include "fpdfsdk/javascript/ijs_context.h"
 #include "fpdfsdk/javascript/ijs_runtime.h"
 #include "third_party/base/stl_util.h"
 
-CPDFSDK_ActionHandler::CPDFSDK_ActionHandler()
-    : m_pFormActionHandler(new CPDFSDK_FormActionHandler) {}
+class NoJsActionHandler {
+ public:
+  NoJsActionHandler(const CPDF_Action&, CPDFSDK_Document*);
+  void Run();
+
+ private:
+  static void DoAction_GoTo(CPDFSDK_Document* pDocument,
+                            const CPDF_Action& action);
+  static void DoAction_GoToR(CPDFSDK_Document* pDocument,
+                             const CPDF_Action& action);
+  static void DoAction_Launch(CPDFSDK_Document* pDocument,
+                              const CPDF_Action& action);
+  static void DoAction_URI(CPDFSDK_Document* pDocument,
+                           const CPDF_Action& action);
+  static void DoAction_Named(CPDFSDK_Document* pDocument,
+                             const CPDF_Action& action);
+  static void DoAction_SetOCGState(CPDFSDK_Document* pDocument,
+                                   const CPDF_Action& action);
+  static void DoAction_Hide(CPDFSDK_Document* pDocument,
+                            const CPDF_Action& action);
+  static void DoAction_SubmitForm(CPDFSDK_Document* pDocument,
+                                  const CPDF_Action& action);
+  static void DoAction_ResetForm(CPDFSDK_Document* pDocument,
+                                 const CPDF_Action& action);
+  static void DoAction_ImportData(CPDFSDK_Document* pDocument,
+                                  const CPDF_Action& action);
+
+  CPDF_Action m_action;
+  CPDFSDK_Document* m_document;
+
+  typedef void (*Callback)(CPDFSDK_Document*, const CPDF_Action&);
+  Callback m_callback = nullptr;

[Tom Sepez, 2016/08/09 21:11:20]

Instead of storing the callback, can we store the action type and switch on it
during the Run() method?

We don't have Chromium's base::bind() here in PDFium, which would be preferred
way of doing this.

+};
+
+CPDFSDK_ActionHandler::CPDFSDK_ActionHandler() {}
 
 CPDFSDK_ActionHandler::~CPDFSDK_ActionHandler() {}
 
 FX_BOOL CPDFSDK_ActionHandler::DoAction_DocOpen(const CPDF_Action& action,
                                                 CPDFSDK_Document* pDocument) {
   std::set<CPDF_Dictionary*> visited;
   return ExecuteDocumentOpenAction(action, pDocument, &visited);
 }
 
 FX_BOOL CPDFSDK_ActionHandler::DoAction_JavaScript(
@@ skipping 90 matching lines @@
   CPDFDoc_Environment* pEnv = pDocument->GetEnv();
   ASSERT(pEnv);
   if (action.GetType() == CPDF_Action::JavaScript) {
     if (pEnv->IsJSInitiated()) {
       CFX_WideString swJS = action.GetJavaScript();
       if (!swJS.IsEmpty()) {
         RunDocumentOpenJavaScript(pDocument, L"", swJS);
       }
     }
   } else {
-    DoAction_NoJs(action, pDocument);
+    NoJsActionHandler(action, pDocument).Run();
   }
 
   for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
     CPDF_Action subaction = action.GetSubAction(i);
     if (!ExecuteDocumentOpenAction(subaction, pDocument, visited))
       return FALSE;
   }
 
   return TRUE;
 }
@@ skipping 23 matching lines @@
         CFX_WideString csInfo;
         FX_BOOL bRet = pContext->RunScript(swJS, &csInfo);
         if (!bRet) {
           // FIXME: return error.
         }
 
         pRuntime->ReleaseContext(pContext);
       }
     }
   } else {
-    DoAction_NoJs(action, pDocument);
+    NoJsActionHandler(action, pDocument).Run();
   }
 
   for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
     CPDF_Action subaction = action.GetSubAction(i);
     if (!ExecuteLinkAction(subaction, pDocument, visited))
       return FALSE;
   }
 
   return TRUE;
 }
 
+FX_BOOL CPDFSDK_ActionHandler::IsValidDocView(CPDFSDK_Document* pDocument) {
+  ASSERT(pDocument);
+  return TRUE;
+}
+
 FX_BOOL CPDFSDK_ActionHandler::ExecuteDocumentPageAction(
     const CPDF_Action& action,
     CPDF_AAction::AActionType type,
     CPDFSDK_Document* pDocument,
     std::set<CPDF_Dictionary*>* visited) {
   CPDF_Dictionary* pDict = action.GetDict();
   if (pdfium::ContainsKey(*visited, pDict))
     return FALSE;
 
   visited->insert(pDict);
 
   CPDFDoc_Environment* pEnv = pDocument->GetEnv();
   ASSERT(pEnv);
   if (action.GetType() == CPDF_Action::JavaScript) {
     if (pEnv->IsJSInitiated()) {
       CFX_WideString swJS = action.GetJavaScript();
       if (!swJS.IsEmpty()) {
         RunDocumentPageJavaScript(pDocument, type, swJS);
       }
     }
   } else {
-    DoAction_NoJs(action, pDocument);
+    NoJsActionHandler(action, pDocument).Run();
   }
 
   if (!IsValidDocView(pDocument))
     return FALSE;
 
   for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
     CPDF_Action subaction = action.GetSubAction(i);
     if (!ExecuteDocumentPageAction(subaction, type, pDocument, visited))
       return FALSE;
   }
@@ skipping 28 matching lines @@
   if (action.GetType() == CPDF_Action::JavaScript) {
     if (pEnv->IsJSInitiated()) {
       CFX_WideString swJS = action.GetJavaScript();
       if (!swJS.IsEmpty()) {
         RunFieldJavaScript(pDocument, pFormField, type, data, swJS);
         if (!IsValidField(pDocument, pFormField->GetFieldDict()))
           return FALSE;
       }
     }
   } else {
-    DoAction_NoJs(action, pDocument);
+    NoJsActionHandler(action, pDocument).Run();
   }
 
   for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
     CPDF_Action subaction = action.GetSubAction(i);
     if (!ExecuteFieldAction(subaction, type, pDocument, pFormField, data,
                             visited))
       return FALSE;
   }
 
   return TRUE;
@@ skipping 24 matching lines @@
         CFX_WideString csInfo;
         FX_BOOL bRet = pContext->RunScript(swJS, &csInfo);
         if (!bRet) {
           // FIXME: return error.
         }
 
         pRuntime->ReleaseContext(pContext);
       }
     }
   } else {
-    DoAction_NoJs(action, pDocument);
+    NoJsActionHandler(action, pDocument).Run();
   }
 
   for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
     CPDF_Action subaction = action.GetSubAction(i);
     if (!ExecuteScreenAction(subaction, type, pDocument, pScreen, visited))
       return FALSE;
   }
 
   return TRUE;
 }
@@ skipping 24 matching lines @@
         CFX_WideString csInfo;
         FX_BOOL bRet = pContext->RunScript(swJS, &csInfo);
         if (!bRet) {
           // FIXME: return error.
         }
 
         pRuntime->ReleaseContext(pContext);
       }
     }
   } else {
-    DoAction_NoJs(action, pDocument);
+    NoJsActionHandler(action, pDocument).Run();
   }
 
   for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
     CPDF_Action subaction = action.GetSubAction(i);
     if (!ExecuteBookMark(subaction, pDocument, pBookmark, visited))
       return FALSE;
   }
 
   return TRUE;
 }
 
-void CPDFSDK_ActionHandler::DoAction_NoJs(const CPDF_Action& action,
-                                          CPDFSDK_Document* pDocument) {
-  ASSERT(pDocument);
-
-  switch (action.GetType()) {
+NoJsActionHandler::NoJsActionHandler(const CPDF_Action& action,
+                                     CPDFSDK_Document* document)
+    : m_action(action), m_document(document) {
+  switch (m_action.GetType()) {
     case CPDF_Action::GoTo:
-      DoAction_GoTo(pDocument, action);
+      m_callback = &DoAction_GoTo;
       break;
     case CPDF_Action::GoToR:
-      DoAction_GoToR(pDocument, action);
-      break;
-    case CPDF_Action::GoToE:
+      m_callback = &DoAction_GoToR;
       break;
     case CPDF_Action::Launch:
-      DoAction_Launch(pDocument, action);
-      break;
-    case CPDF_Action::Thread:
+      m_callback = &DoAction_Launch;
       break;
     case CPDF_Action::URI:
-      DoAction_URI(pDocument, action);
-      break;
-    case CPDF_Action::Sound:
-      break;
-    case CPDF_Action::Movie:
+      m_callback = &DoAction_URI;
       break;
     case CPDF_Action::Hide:
-      if (m_pFormActionHandler) {
-        m_pFormActionHandler->DoAction_Hide(action, pDocument);
-      }
+      m_callback = &DoAction_Hide;
       break;
     case CPDF_Action::Named:
-      DoAction_Named(pDocument, action);
+      m_callback = &DoAction_Named;
       break;
     case CPDF_Action::SubmitForm:
-      if (m_pFormActionHandler) {
-        m_pFormActionHandler->DoAction_SubmitForm(action, pDocument);
-      }
+      m_callback = &DoAction_SubmitForm;
       break;
     case CPDF_Action::ResetForm:
-      if (m_pFormActionHandler) {
-        m_pFormActionHandler->DoAction_ResetForm(action, pDocument);
-      }
+      m_callback = &DoAction_ResetForm;
       break;
     case CPDF_Action::ImportData:
-      if (m_pFormActionHandler) {
-        m_pFormActionHandler->DoAction_ImportData(action, pDocument);
-      }
+      m_callback = &DoAction_ImportData;
       break;
     case CPDF_Action::JavaScript:
       ASSERT(FALSE);
       break;
     case CPDF_Action::SetOCGState:
-      DoAction_SetOCGState(pDocument, action);
+      m_callback = &DoAction_SetOCGState;
       break;
+    case CPDF_Action::GoToE:
+    case CPDF_Action::Thread:
+    case CPDF_Action::Sound:
+    case CPDF_Action::Movie:
     case CPDF_Action::Rendition:
-      break;
     case CPDF_Action::Trans:
-      break;
     case CPDF_Action::GoTo3DView:
       break;
     default:
       break;
   }
 }
 
-FX_BOOL CPDFSDK_ActionHandler::IsValidDocView(CPDFSDK_Document* pDocument) {
-  ASSERT(pDocument);
-  return TRUE;
+void NoJsActionHandler::Run() {
+  if (!m_callback)
+    return;
+
+  ASSERT(m_document);
+  m_callback(m_document, m_action);
 }
 
-void CPDFSDK_ActionHandler::DoAction_GoTo(CPDFSDK_Document* pDocument,
-                                          const CPDF_Action& action) {
+void NoJsActionHandler::DoAction_GoTo(CPDFSDK_Document* pDocument,
+                                      const CPDF_Action& action) {
   ASSERT(action.GetDict());
 
   CPDF_Document* pPDFDocument = pDocument->GetPDFDocument();
   ASSERT(pPDFDocument);
 
   CPDF_Dest MyDest = action.GetDest(pPDFDocument);
   int nPageIndex = MyDest.GetPageIndex(pPDFDocument);
   int nFitType = MyDest.GetZoomMode();
   const CPDF_Array* pMyArray = ToArray(MyDest.GetObject());
   float* pPosAry = nullptr;
   int sizeOfAry = 0;
   if (pMyArray) {
     pPosAry = new float[pMyArray->GetCount()];
     int j = 0;
     for (size_t i = 2; i < pMyArray->GetCount(); i++) {
       pPosAry[j++] = pMyArray->GetFloatAt(i);
     }
     sizeOfAry = j;
   }
 
   CPDFDoc_Environment* pApp = pDocument->GetEnv();
   pApp->FFI_DoGoToAction(nPageIndex, nFitType, pPosAry, sizeOfAry);
   delete[] pPosAry;
 }
 
-void CPDFSDK_ActionHandler::DoAction_GoToR(CPDFSDK_Document* pDocument,
-                                           const CPDF_Action& action) {}
+void NoJsActionHandler::DoAction_GoToR(CPDFSDK_Document* pDocument,
+                                       const CPDF_Action& action) {}
 
-void CPDFSDK_ActionHandler::DoAction_Launch(CPDFSDK_Document* pDocument,
-                                            const CPDF_Action& action) {}
+void NoJsActionHandler::DoAction_Launch(CPDFSDK_Document* pDocument,
+                                        const CPDF_Action& action) {}
 
-void CPDFSDK_ActionHandler::DoAction_URI(CPDFSDK_Document* pDocument,
-                                         const CPDF_Action& action) {
+void NoJsActionHandler::DoAction_URI(CPDFSDK_Document* pDocument,
+                                     const CPDF_Action& action) {
   ASSERT(action.GetDict());
 
   CPDFDoc_Environment* pApp = pDocument->GetEnv();
   CFX_ByteString sURI = action.GetURI(pDocument->GetPDFDocument());
   pApp->FFI_DoURIAction(sURI.c_str());
 }
 
-void CPDFSDK_ActionHandler::DoAction_Named(CPDFSDK_Document* pDocument,
-                                           const CPDF_Action& action) {
+void NoJsActionHandler::DoAction_Named(CPDFSDK_Document* pDocument,
+                                       const CPDF_Action& action) {
   ASSERT(action.GetDict());
 
   CFX_ByteString csName = action.GetNamedAction();
   pDocument->GetEnv()->FFI_ExecuteNamedAction(csName.c_str());
 }
 
-void CPDFSDK_ActionHandler::DoAction_SetOCGState(CPDFSDK_Document* pDocument,
-                                                 const CPDF_Action& action) {}
+void NoJsActionHandler::DoAction_SetOCGState(CPDFSDK_Document* pDocument,
+                                             const CPDF_Action& action) {}
 
 void CPDFSDK_ActionHandler::RunFieldJavaScript(CPDFSDK_Document* pDocument,
                                                CPDF_FormField* pFormField,
                                                CPDF_AAction::AActionType type,
                                                PDFSDK_FieldAction& data,
                                                const CFX_WideString& script) {
   ASSERT(type != CPDF_AAction::Calculate);
   ASSERT(type != CPDF_AAction::Format);
 
   IJS_Runtime* pRuntime = pDocument->GetJsRuntime();
@@ skipping 107 matching lines @@
 
   CFX_WideString csInfo;
   FX_BOOL bRet = pContext->RunScript(script, &csInfo);
   if (!bRet) {
     // FIXME: return error.
   }
 
   pRuntime->ReleaseContext(pContext);
 }
 
-FX_BOOL CPDFSDK_FormActionHandler::DoAction_Hide(const CPDF_Action& action,
-                                                 CPDFSDK_Document* pDocument) {
+void NoJsActionHandler::DoAction_Hide(CPDFSDK_Document* pDocument,
+                                      const CPDF_Action& action) {
   CPDFSDK_InterForm* pInterForm = pDocument->GetInterForm();
-  if (pInterForm->DoAction_Hide(action)) {
+  if (pInterForm->DoAction_Hide(action))
     pDocument->SetChangeMark();
-    return TRUE;
-  }
-
-  return FALSE;
 }
 
-FX_BOOL CPDFSDK_FormActionHandler::DoAction_SubmitForm(
-    const CPDF_Action& action,
-    CPDFSDK_Document* pDocument) {
+void NoJsActionHandler::DoAction_SubmitForm(CPDFSDK_Document* pDocument,
+                                            const CPDF_Action& action) {
   CPDFSDK_InterForm* pInterForm = pDocument->GetInterForm();
-  return pInterForm->DoAction_SubmitForm(action);
+  pInterForm->DoAction_SubmitForm(action);
 }
 
-FX_BOOL CPDFSDK_FormActionHandler::DoAction_ResetForm(
-    const CPDF_Action& action,
-    CPDFSDK_Document* pDocument) {
+void NoJsActionHandler::DoAction_ResetForm(CPDFSDK_Document* pDocument,
+                                           const CPDF_Action& action) {
   CPDFSDK_InterForm* pInterForm = pDocument->GetInterForm();
-  return pInterForm->DoAction_ResetForm(action);
+  pInterForm->DoAction_ResetForm(action);
 }
 
-FX_BOOL CPDFSDK_FormActionHandler::DoAction_ImportData(
-    const CPDF_Action& action,
-    CPDFSDK_Document* pDocument) {
+void NoJsActionHandler::DoAction_ImportData(CPDFSDK_Document* pDocument,
+                                            const CPDF_Action& action) {
   CPDFSDK_InterForm* pInterForm = pDocument->GetInterForm();
-  if (pInterForm->DoAction_ImportData(action)) {
+  if (pInterForm->DoAction_ImportData(action))
     pDocument->SetChangeMark();
-    return TRUE;
-  }
-
-  return FALSE;
 }