Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py

Issue 2227163002: Added integration test to Chrome Proxy to verify fallback to HTTP after bad HTTPS response from pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py b/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
index 04740c5d6e8b4a687c32f75fad053dce207efc57..1d7b6947bc6ae991cf8a2960f9bcc7b85b0fbb50 100644
--- a/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
@@ -10,6 +10,20 @@ from telemetry import benchmark
DESKTOP_PLATFORMS = ['mac', 'linux', 'win', 'chromeos']
WEBVIEW_PLATFORMS = ['android-webview', 'android-webview-shell']
+class ChromeProxyBadHTTPSFallback(ChromeProxyBenchmark):
+ """Check that the client falls back to HTTP on bad HTTPS response.
+
+ If the HTTPS proxy responds with a bad response code (like 500) then the
+ client should fallback to HTTP.
+ """
+ tag = 'badhttps_bypass'
+ test = measurements.ChromeProxyBadHTTPSFallback
+ page_set = pagesets.BadHTTPSFallbackStorySet
+
+ @classmethod
+ def Name(cls):
+ return 'chrome_proxy_benchmark.badhttps_fallback.badhttps_fallback'
+
class ChromeProxyClientType(ChromeProxyBenchmark):
tag = 'client_type'
test = measurements.ChromeProxyClientType
@@ -316,4 +330,4 @@ class ChromeProxyPingback(ChromeProxyBenchmark):
@classmethod
def Name(cls):
- return 'chrome_proxy_benchmark.pingback'
+ return 'chrome_proxy_benchmark.pingback'

Powered by Google App Engine
This is Rietveld 408576698