Added integration test to Chrome Proxy to verify fallback to HTTP after bad HTTPS response from pro…

tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import logging
 import urlparse
 
 from common import chrome_proxy_measurements as measurements
 from common.chrome_proxy_measurements import ChromeProxyValidation
@@ skipping 163 matching lines @@
     queries.append('respBody=%s' % base64.b64encode(respBody))
   if len(queries) == 0:
     return url
   "&".join(queries)
   # url has query already
   if urlparse.urlparse(url).query:
     return url + '&' + "&".join(queries)
   else:
     return url + '?' + "&".join(queries)
 
+class ChromeProxyBadHTTPSFallback(ChromeProxyValidation):
+  """Checks the client falls back to HTTP proxy when HTTPS proxy errors."""
+
+  def __init__(self):
+    super(ChromeProxyBadHTTPSFallback, self).__init__(
+        restart_after_each_page=True,
+        metrics=metrics.ChromeProxyMetric())
+    self._is_chrome_proxy_enabled = True
+
+  def CustomizeBrowserOptions(self, options):
+    super(ChromeProxyBadHTTPSFallback, self).CustomizeBrowserOptions(
+        options)
+    options.AppendExtraBrowserArgs('--data-reduction-proxy-http-proxies='
+        'https://%s;http://compress.googlezip.net' % _TEST_SERVER)

[bustamante, 2016/08/12 20:01:57]

In some cases we'll want to set the proxy to an internal url, which we can do
when calling the test.  But this may overwrite that.  Have you tried running the
test setting the proxy to XT with command line flags?

I agree we can't check in internal url's since it's public

[Robert Ogden, 2016/08/15 17:13:14]

Yes, and it can be overridden from the command line with
--extra-browser-args="--data-reduction-proxy-http-proxies=%s"

+
+  def AddResults(self, tab, results):
+    self._metrics.AddResultsForBadHTTPSFallback(tab, results)
 
 class ChromeProxyHTTPFallbackProbeURL(ChromeProxyValidation):
   """Correctness measurement for proxy fallback.
 
   In this test, the probe URL does not return 'OK'. Chrome is expected
   to use the fallback proxy.
   """
 
   def __init__(self):
     super(ChromeProxyHTTPFallbackProbeURL, self).__init__(
@@ skipping 476 matching lines @@
         metrics=metrics.ChromeProxyMetric())
 
   def CustomizeBrowserOptions(self, options):
     super(ChromeProxyPingback, self).CustomizeBrowserOptions(options)
     options.AppendExtraBrowserArgs(
       '--enable-data-reduction-proxy-force-pingback')
     options.AppendExtraBrowserArgs(
       '--enable-stats-collection-bindings')
 
   def AddResults(self, tab, results):
-    self._metrics.AddResultsForPingback(tab, results)
+    self._metrics.AddResultsForPingback(tab, results)