Update bulidbucket client

Update bulidbucket client

- Move to //buildbucket
- Add retries
- Simplify, in particular do not unmarshal and then re-marshal responses
- add doc.go
- consolidate isLocalHost funcs

R=vadimsh@chromium.org, robertocn@chromium.org
BUG=627199
Committed: https://github.com/luci/luci-go/commit/4172212f34db48ecc02aab897fcf38246ccf5682

[nodir, 2016-08-09 18:26:01]

Description was changed from

==========
Update bulidbucket client

- Move to //buildbucket
- Add retries
- Simplify, in particular do not unmarshal and then re-marshal responses
- add doc.go

R=vadimsh@chromium.org, robertocn@chromium.org
BUG=627199
==========

to

==========
Update bulidbucket client

- Move to //buildbucket
- Add retries
- Simplify, in particular do not unmarshal and then re-marshal responses
- add doc.go
- consolidate isLocalHost funcs

R=vadimsh@chromium.org, robertocn@chromium.org
BUG=627199
==========

[nodir, 2016-08-09 18:54:09]

Patchset #2 (id:20001) has been deleted

[nodir, 2016-08-09 18:58:24]

PTAL

[Vadim Sh., 2016-08-09 19:09:24]

lgtm with nits

https://codereview.chromium.org/2227113002/diff/60001/buildbucket/client/cmd/...
File buildbucket/client/cmd/buildbucket/client.go (right):

https://codereview.chromium.org/2227113002/diff/60001/buildbucket/client/cmd/...
buildbucket/client/cmd/buildbucket/client.go:58: res, err := c.HTTP.Do(req)
use ctxhttp.Do(ctx, c.HTTP, req) to support context timeouts and cancelation

https://codereview.chromium.org/2227113002/diff/60001/common/lhttp/utils.go
File common/lhttp/utils.go (right):

https://codereview.chromium.org/2227113002/diff/60001/common/lhttp/utils.go#n...
common/lhttp/utils.go:48: case host == "[::1]", strings.HasPrefix(host,
"[::1]:"):
strictly speaking 0:0:0:0:0:0:0:1 is also localhost and 00:00:00:00:00:00:00:01

Use https://golang.org/pkg/net/#SplitHostPort and ParseIP and IP.IsLoopback.

[nodir, 2016-08-09 22:56:31]

https://codereview.chromium.org/2227113002/diff/60001/buildbucket/client/cmd/...
File buildbucket/client/cmd/buildbucket/client.go (right):

https://codereview.chromium.org/2227113002/diff/60001/buildbucket/client/cmd/...
buildbucket/client/cmd/buildbucket/client.go:58: res, err := c.HTTP.Do(req)
On 2016/08/09 19:09:23, Vadim Sh. wrote:
> use ctxhttp.Do(ctx, c.HTTP, req) to support context timeouts and cancelation

oops

https://codereview.chromium.org/2227113002/diff/60001/common/lhttp/utils.go
File common/lhttp/utils.go (right):

https://codereview.chromium.org/2227113002/diff/60001/common/lhttp/utils.go#n...
common/lhttp/utils.go:48: case host == "[::1]", strings.HasPrefix(host,
"[::1]:"):
On 2016/08/09 19:09:24, Vadim Sh. wrote:
> strictly speaking 0:0:0:0:0:0:0:1 is also localhost and
00:00:00:00:00:00:00:01
> 
> Use https://golang.org/pkg/net/#SplitHostPort and ParseIP and IP.IsLoopback.

Done.

[nodir, 2016-08-09 22:57:08]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-08-09 22:57:08]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2227113002/#ps80001
(title: "loopback")

[commit-bot: I haz the power, 2016-08-09 22:57:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 22:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 22:58:50]

Try jobs failed on following builders:
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/308a580e2e403c10)
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/308a580daca27510)

[nodir, 2016-08-09 23:15:25]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-08-09 23:15:26]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2227113002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-09 23:15:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 23:26:29]

Description was changed from

==========
Update bulidbucket client

- Move to //buildbucket
- Add retries
- Simplify, in particular do not unmarshal and then re-marshal responses
- add doc.go
- consolidate isLocalHost funcs

R=vadimsh@chromium.org, robertocn@chromium.org
BUG=627199
==========

to

==========
Update bulidbucket client

- Move to //buildbucket
- Add retries
- Simplify, in particular do not unmarshal and then re-marshal responses
- add doc.go
- consolidate isLocalHost funcs

R=vadimsh@chromium.org, robertocn@chromium.org
BUG=627199

Committed:
https://github.com/luci/luci-go/commit/4172212f34db48ecc02aab897fcf38246ccf5682
==========

[commit-bot: I haz the power, 2016-08-09 23:26:30]

Committed patchset #5 (id:100001) as
https://github.com/luci/luci-go/commit/4172212f34db48ecc02aab897fcf38246ccf5682