Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2227083002: Remove net::BidirectionalStream::Cancel (Closed)

Created:
4 years, 4 months ago by xunjieli
Modified:
4 years, 4 months ago
Reviewers:
mef
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove net::BidirectionalStream::Cancel This CL removes the unused Cancel() method. This simplifies the interface, and make it easier to reason about, since there is one fewer state to worry about. BUG=635548 Committed: https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212 Cr-Commit-Position: refs/heads/master@{#411135}

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -282 lines) Patch
M net/http/bidirectional_stream.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/http/bidirectional_stream.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M net/http/bidirectional_stream_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 21 chunks +95 lines, -96 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 7 chunks +29 lines, -73 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 5 chunks +13 lines, -70 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
xunjieli
Hi Misha, PTAL. Thanks!
4 years, 4 months ago (2016-08-09 18:25:24 UTC) #6
mef
lgtm
4 years, 4 months ago (2016-08-10 01:14:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227083002/20001
4 years, 4 months ago (2016-08-10 13:39:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227083002/40001
4 years, 4 months ago (2016-08-10 14:02:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/119805)
4 years, 4 months ago (2016-08-10 15:28:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227083002/40001
4 years, 4 months ago (2016-08-10 17:18:09 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120037)
4 years, 4 months ago (2016-08-10 19:32:50 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227083002/40001
4 years, 4 months ago (2016-08-10 19:35:03 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-10 20:26:36 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 20:28:42 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ff75c568c5feb797f1dd2dec7bd74577f8e0212
Cr-Commit-Position: refs/heads/master@{#411135}

Powered by Google App Engine
This is Rietveld 408576698