Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2227033002:
Fix quick view's toolbar and metadata area to consider RTL (Closed)
|
Created:
4 years, 4 months ago by harukam Modified:
4 years, 4 months ago Reviewers:
fukino CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix quick view's toolbar and metadata area to consider RTL
BUG=634224
TEST=manually tested
Committed: https://crrev.com/9e3edac68cb0b3a773f6e7c1b0d4d352f4e7fc32
Cr-Commit-Position: refs/heads/master@{#410962}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Fix quick view's toolbar and metadata area to consider RTL #Patch Set 3 : Fix quick view's toolbar and metadata area to consider RTL #Messages
Total messages: 23 (12 generated)
Description was changed from ========== Fix quick view's toolbar and metadata area to consider RTL BUG=634224 TEST=manually tested ========== to ========== Fix quick view's toolbar and metadata area to consider RTL BUG=634224 TEST=manually tested ==========
harukam@chromium.org changed reviewers: + fukino@chromium.org, harukam@chromium.org
PTAL
https://codereview.chromium.org/2227033002/diff/1/ui/file_manager/file_manage... File ui/file_manager/file_manager/foreground/elements/files_quick_view.css (right): https://codereview.chromium.org/2227033002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/elements/files_quick_view.css:70: margin-right: auto; Use 2 spaces to indents. https://codereview.chromium.org/2227033002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/elements/files_quick_view.css:116: right: auto; ditto https://codereview.chromium.org/2227033002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/elements/files_quick_view.css:143: right: auto; ditto
PTAL https://codereview.chromium.org/2227033002/diff/1/ui/file_manager/file_manage... File ui/file_manager/file_manager/foreground/elements/files_quick_view.css (right): https://codereview.chromium.org/2227033002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/elements/files_quick_view.css:70: margin-right: auto; On 2016/08/09 06:49:57, fukino wrote: > Use 2 spaces to indents. Done. https://codereview.chromium.org/2227033002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/elements/files_quick_view.css:116: right: auto; On 2016/08/09 06:49:57, fukino wrote: > ditto Done. https://codereview.chromium.org/2227033002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/elements/files_quick_view.css:143: right: auto; On 2016/08/09 06:49:57, fukino wrote: > ditto Done.
lgtm. Thanks!
The CQ bit was checked by harukam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
harukam@chromium.org changed reviewers: - harukam@chromium.org
harukam@chromium.org changed reviewers: + harukam@chromium.org
PTAL
fukino@chromium.org changed reviewers: - harukam@chromium.org
still lgtm.
The CQ bit was checked by harukam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix quick view's toolbar and metadata area to consider RTL BUG=634224 TEST=manually tested ========== to ========== Fix quick view's toolbar and metadata area to consider RTL BUG=634224 TEST=manually tested ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix quick view's toolbar and metadata area to consider RTL BUG=634224 TEST=manually tested ========== to ========== Fix quick view's toolbar and metadata area to consider RTL BUG=634224 TEST=manually tested Committed: https://crrev.com/9e3edac68cb0b3a773f6e7c1b0d4d352f4e7fc32 Cr-Commit-Position: refs/heads/master@{#410962} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9e3edac68cb0b3a773f6e7c1b0d4d352f4e7fc32 Cr-Commit-Position: refs/heads/master@{#410962}
Message was sent while issue was closed.
Description was changed from ========== Fix quick view's toolbar and metadata area to consider RTL BUG=634224 TEST=manually tested Committed: https://crrev.com/9e3edac68cb0b3a773f6e7c1b0d4d352f4e7fc32 Cr-Commit-Position: refs/heads/master@{#410962} ========== to ========== Fix quick view's toolbar and metadata area to consider RTL BUG=634224 TEST=manually tested Committed: https://crrev.com/9e3edac68cb0b3a773f6e7c1b0d4d352f4e7fc32 Cr-Commit-Position: refs/heads/master@{#410962} ==========
Message was sent while issue was closed.
fukino@chromium.org changed reviewers: - harukam@chromium.org |
