Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2227003002: CSS: animated text-decoration-line overrides inline style (Closed)

Created:
4 years, 4 months ago by Eric Willigers
Modified:
4 years, 4 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: animated text-decoration-line overrides inline style The text-decoration-line of an element can add to the inherited text-decoration-line. However, StyleAdjuster::adjustComputedStyle is called both before and after animations are applied, and the text-decoration-line from the inline style (or SVG attribute) was being combined with the text-decoration-line from the CSS or Web Animation. BUG=620037 Committed: https://crrev.com/5243763790094312f18657ffa69c21ba4f613566 Cr-Commit-Position: refs/heads/master@{#410966}

Patch Set 1 : test #

Patch Set 2 : StyleAdjuster uses parent appliedTextDecorations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/animations/text-decoration.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/text-decoration-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Eric Willigers
4 years, 4 months ago (2016-08-10 02:37:38 UTC) #10
alancutter (OOO until 2018)
lgtm
4 years, 4 months ago (2016-08-10 02:54:08 UTC) #13
Timothy Loh
lgtm
4 years, 4 months ago (2016-08-10 03:18:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227003002/40001
4 years, 4 months ago (2016-08-10 03:44:05 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-10 05:28:05 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 05:29:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5243763790094312f18657ffa69c21ba4f613566
Cr-Commit-Position: refs/heads/master@{#410966}

Powered by Google App Engine
This is Rietveld 408576698