Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2226963003: Work around simctl error when moving from Xcode 7 to Xcode 8. (Closed)

Created:
4 years, 4 months ago by justincohen
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around simctl error when moving from Xcode 7 to Xcode 8. BUG= TBR=rohitrao@chromium.org Committed: https://crrev.com/83610f5d8af84ad969d47824120324cec2bcf8e2 Cr-Commit-Position: refs/heads/master@{#410636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M testing/iossim/iossim.mm View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226963003/1
4 years, 4 months ago (2016-08-09 10:39:22 UTC) #3
stkhapugin
lgtm
4 years, 4 months ago (2016-08-09 10:41:55 UTC) #5
justincohen
rohitrao@ TBRing to try to get downstream green.
4 years, 4 months ago (2016-08-09 10:42:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 11:55:15 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/83610f5d8af84ad969d47824120324cec2bcf8e2 Cr-Commit-Position: refs/heads/master@{#410636}
4 years, 4 months ago (2016-08-09 11:57:24 UTC) #11
justincohen
4 years, 4 months ago (2016-08-12 21:33:39 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2239233004/ by justincohen@chromium.org.

The reason for reverting is: This is causing a timeout where we no longer run
Xcode 7.  Try removing it..

Powered by Google App Engine
This is Rietveld 408576698