[MD settings] change height and width of checkboxes

[MD settings] change height and width of checkboxes

This CL makes settings-checkboxes change to a two-line height if the
secondary text is set. The width of the checkbox is expanded to fill
more of the row. A couple instances of .two-line used around a
settings-checkbox have been removed.

BUG=634172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926
Cr-Commit-Position: refs/heads/master@{#410827}

[dschuyler, 2016-08-09 00:37:25]

Description was changed from

==========
[MD settings] change height and width of checkboxes

This CL makes settings-checkboxes change to a two-line height if the
secondary text is set. The width of the checkbox is expanded to fill
more of the row. A couple instances of .two-line used around a
settings-checkbox have been removed.

BUG=634172
==========

to

==========
[MD settings] change height and width of checkboxes

This CL makes settings-checkboxes change to a two-line height if the
secondary text is set. The width of the checkbox is expanded to fill
more of the row. A couple instances of .two-line used around a
settings-checkbox have been removed.

BUG=634172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-08-09 00:37:28]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 00:37:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-09 00:39:26]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 00:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-09 00:40:08]

Patchset #1 (id:1) has been deleted

[dschuyler, 2016-08-09 00:41:31]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[dschuyler, 2016-08-09 00:41:31]

This is to make the checkbox sizing more automated (and consistent).

[stevenjb, 2016-08-09 00:47:10]

https://codereview.chromium.org/2226963002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_checkbox.html (right):

https://codereview.chromium.org/2226963002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_checkbox.html:42: <div
id="outerRow" noSubLabel$="[[!subLabel]]">
If we remove the 'layout horizontal' will the cr-policy-pref-indicator show up
correctly?

[commit-bot: I haz the power, 2016-08-09 00:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:47:29]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[dschuyler, 2016-08-09 01:05:38]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 01:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-09 01:09:24]

https://codereview.chromium.org/2226963002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_checkbox.html (right):

https://codereview.chromium.org/2226963002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_checkbox.html:42: <div
id="outerRow" noSubLabel$="[[!subLabel]]">
On 2016/08/09 00:47:09, stevenjb wrote:
> If we remove the 'layout horizontal' will the cr-policy-pref-indicator show up
> correctly?

It shows up with either Patch #1 or #2. With Patch
#1 the policy icon is on the right. With patch #2
the icon follows just after the checkbox labels.
I'm open to either (as being correct), I'm not sure
of a mock or spec for it exactly.

[commit-bot: I haz the power, 2016-08-09 01:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:12:57]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[stevenjb, 2016-08-09 01:13:13]

On 2016/08/09 01:09:24, dschuyler wrote:
>
https://codereview.chromium.org/2226963002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/controls/settings_checkbox.html
(right):
> 
>
https://codereview.chromium.org/2226963002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/controls/settings_checkbox.html:42: <div
> id="outerRow" noSubLabel$="[[!subLabel]]">
> On 2016/08/09 00:47:09, stevenjb wrote:
> > If we remove the 'layout horizontal' will the cr-policy-pref-indicator show
up
> > correctly?
> 
> It shows up with either Patch #1 or #2. With Patch
> #1 the policy icon is on the right. With patch #2
> the icon follows just after the checkbox labels.
> I'm open to either (as being correct), I'm not sure
> of a mock or spec for it exactly.

Can you describe more or show a screenshot for #2, "the icon follows just after
the checkbox labels". I'm unclear how that differs from "on the right". Does
that mean that in #1 it is on the far right when the checkbox is stretched
horizontally? In that case #2 would be better, assuming everything is also
centered correctly. Basically, as long as that was looked at and it seems
correct, then lgtm.

[dschuyler, 2016-08-09 01:22:03]

On 2016/08/09 01:13:13, stevenjb wrote:
> On 2016/08/09 01:09:24, dschuyler wrote:
> >
>
https://codereview.chromium.org/2226963002/diff/20001/chrome/browser/resource...
> > File chrome/browser/resources/settings/controls/settings_checkbox.html
> (right):
> > 
> >
>
https://codereview.chromium.org/2226963002/diff/20001/chrome/browser/resource...
> > chrome/browser/resources/settings/controls/settings_checkbox.html:42: <div
> > id="outerRow" noSubLabel$="[[!subLabel]]">
> > On 2016/08/09 00:47:09, stevenjb wrote:
> > > If we remove the 'layout horizontal' will the cr-policy-pref-indicator
show
> up
> > > correctly?
> > 
> > It shows up with either Patch #1 or #2. With Patch
> > #1 the policy icon is on the right. With patch #2
> > the icon follows just after the checkbox labels.
> > I'm open to either (as being correct), I'm not sure
> > of a mock or spec for it exactly.
> 
> Can you describe more or show a screenshot for #2, "the icon follows just
after
> the checkbox labels". I'm unclear how that differs from "on the right". Does
> that mean that in #1 it is on the far right when the checkbox is stretched
> horizontally? In that case #2 would be better, assuming everything is also
> centered correctly. Basically, as long as that was looked at and it seems
> correct, then lgtm.

I sent screen shots to stevenjb@ with several situations such as 
- no subtext
- with subtext (shorter than the main label)
- with a long subtext
All seemed good.

[dschuyler, 2016-08-09 20:59:43]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-08-09 21:00:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 21:28:39]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-09 21:31:17]

Description was changed from

==========
[MD settings] change height and width of checkboxes

This CL makes settings-checkboxes change to a two-line height if the
secondary text is set. The width of the checkbox is expanded to fill
more of the row. A couple instances of .two-line used around a
settings-checkbox have been removed.

BUG=634172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] change height and width of checkboxes

This CL makes settings-checkboxes change to a two-line height if the
secondary text is set. The width of the checkbox is expanded to fill
more of the row. A couple instances of .two-line used around a
settings-checkbox have been removed.

BUG=634172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926
Cr-Commit-Position: refs/heads/master@{#410827}
==========

[commit-bot: I haz the power, 2016-08-09 21:31:18]

Patchset 2 (id:??) landed as
https://crrev.com/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926
Cr-Commit-Position: refs/heads/master@{#410827}