scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json - Issue 2226943002: build_state._is_build_archived is a method, not a property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json

Issue 2226943002: build_state._is_build_archived is a method, not a property. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json ('k') | scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json

diff --git a/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json

index f130292357983d38c496c4b6f16b1e9531b34c73..e365866fa5be284c5031448b09eeeb067f546be8 100644

--- a/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json

+++ b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json

@@ -504,6 +504,26 @@

{

"cmd": [

+ "/opt/infra-tools/buildbucket",

+ "get",

+ "--host",

+ "cr-buildbucket.appspot.com",

+ "9016911228971028736"

+ ],

+ "cwd": "[BUILDER_CACHE]/linux_perf_bisect",

+ "name": "buildbucket.get (2)",

+ "stdout": "/path/to/tmp/json",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@json.output@{@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"build\": {@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"result\": \"SUCCESS\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ }@@@",

+ "@@@STEP_LOG_LINE@json.output@}@@@",

+ "@@@STEP_LOG_END@json.output@@@"

+ ]

+ },

+ {

+ "cmd": [

"python",

"-u",

"\nimport os, sys\nfrom common import chromium_utils # Error? See https://crbug.com/584783.\n\n\nif os.path.exists(sys.argv[1]):\n chromium_utils.RemoveDirectory(sys.argv[1])\n",