Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: scripts/slave/recipe_modules/perf_try/build_state.py

Issue 2226943002: build_state._is_build_archived is a method, not a property. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/perf_try/build_state.py
diff --git a/scripts/slave/recipe_modules/perf_try/build_state.py b/scripts/slave/recipe_modules/perf_try/build_state.py
index 2d732ab2bc9d29c207bc1aafae4f3dae68e1f577..73673f5f024b345de5181ca9bd95621bf4b8c9d6 100644
--- a/scripts/slave/recipe_modules/perf_try/build_state.py
+++ b/scripts/slave/recipe_modules/perf_try/build_state.py
@@ -48,11 +48,19 @@ class BuildState(object):
return 'gs://%s/Linux Builder/full-build-linux' % self.bucket
def _is_completed(self):
- result = self.api.m.buildbucket.get_build(self.build_id)
+ result = self.api.m.buildbucket.get_build(
+ self.build_id,
+ step_test_data=lambda: self.api.m.json.test_api.output_stream(
+ {'build': {'status': 'COMPLETED'}}
+ ))
return result.stdout['build']['status'] == 'COMPLETED'
def _is_build_archived(self): # pragma: no cover
- result = self.api.m.buildbucket.get_build(self.build_id)
+ result = self.api.m.buildbucket.get_build(
+ self.build_id,
+ step_test_data=lambda: self.api.m.json.test_api.output_stream(
+ {'build': {'result': 'SUCCESS'}}
+ ))
return result.stdout['build']['result'] == 'SUCCESS'
# Duplicate code from auto_bisect.bisector.get_builder_bot_for_this_platform
@@ -113,7 +121,7 @@ class BuildState(object):
def wait_for(self): # pragma: no cover
while True:
if self._is_completed():
- if self._is_build_archived:
+ if self._is_build_archived():
break
raise self.api.m.step.StepFailure('Build %s fails' % self.build_id)
else:
« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698