Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2226943002: build_state._is_build_archived is a method, not a property. (Closed)

Created:
4 years, 4 months ago by RobertoCN
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2288 lines, -300 lines) Patch
M scripts/slave/recipe_modules/perf_try/build_state.py View 2 chunks +11 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 2 chunks +49 lines, -9 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json View 2 chunks +49 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
RobertoCN
4 years, 4 months ago (2016-08-08 23:15:49 UTC) #1
sullivan
lgtm
4 years, 4 months ago (2016-08-08 23:22:29 UTC) #2
aiolos (Not reviewing)
lgtm
4 years, 4 months ago (2016-08-08 23:28:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226943002/1
4 years, 4 months ago (2016-08-08 23:36:36 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 23:41:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/14ed81de22b5635905c2...

Powered by Google App Engine
This is Rietveld 408576698