fix #26812, function types should support the call method

fix #26812, function types should support the call method

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/efa73a440e66364abd1b278a27c245d724c760e5

[Jennifer Messerly, 2016-08-09 17:14:21]

jmesserly@google.com changed reviewers:
+ leafp@google.com, vsm@google.com

[Jennifer Messerly, 2016-08-09 17:14:21]

Probably more brokenness in element_resolver but this should fix the immediate
problem

https://codereview.chromium.org/2226903003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/2226903003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/element_resolver.dart:1528: staticType =
_resolver.typeProvider.functionType;
... wow

[Leaf, 2016-08-10 07:38:14]

lgtm.  That thing with the function type looks really bad unless I'm missing
something, since _getStaticType seems to still be used in lots of places. Can
you look into implications and file a bug?

https://codereview.chromium.org/2226903003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/2226903003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/element_resolver.dart:1528: staticType =
_resolver.typeProvider.functionType;
On 2016/08/09 17:14:21, John Messerly wrote:
> ... wow

Wat?  Am I crazy, or does this mean that everything is completely broken
everywhere?

[Jennifer Messerly, 2016-08-10 15:27:45]

yeah it's crazy huh? filed https://github.com/dart-lang/sdk/issues/27050

https://codereview.chromium.org/2226903003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/2226903003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/element_resolver.dart:1528: staticType =
_resolver.typeProvider.functionType;
On 2016/08/10 07:38:14, Leaf wrote:
> On 2016/08/09 17:14:21, John Messerly wrote:
> > ... wow
> 
> Wat?  Am I crazy, or does this mean that everything is completely broken
> everywhere? 

yeah it's *super* scary. I looked a bit yesterday... and it seems mostly safe:
unary/binary/opassign ops, index expression, and super calls, which aren't
supported for function types. One place that's probably broken is property get
(tear-offs) if you're allowed to tear off the ".call" method from functions. I
didn't get a chance to dig into that one.

I actually tried at first guarding the code against !strongMode on this line,
but that broke some of the places where they special case "isDartCoreFunction". 
For example, the == path got busted and it didn't know you could compare
functions for equality. Wasn't sure how long that bug trail would go.

There are other strange things in here too, like FunctionExpressionInvocation
where it just uses ".staticType" ... not sure if that's right either given the
"_resolveTypeParameter" call below.

But yeah I can file a bug. It certainly felt like uncovering a skeleton in the
closet :)

[Jennifer Messerly, 2016-08-10 15:29:11]

btw Vijay had a good point, this isn't a soundness bug at least, because we do
treat it as a dcall.

[Jennifer Messerly, 2016-08-10 17:33:29]

Description was changed from

==========
fix #26812, function types should support the call method
==========

to

==========
fix #26812, function types should support the call method

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/efa73a440e66364abd1b278a27c245d724c760e5
==========

[Jennifer Messerly, 2016-08-10 17:33:30]

Committed patchset #1 (id:1) manually as
efa73a440e66364abd1b278a27c245d724c760e5 (presubmit successful).