|
|
Chromium Code Reviews
DescriptionSpeculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester
BUG=635624
TBR=dfalcantara
Committed: https://crrev.com/dab69e22fde245ba5fb7b430e26f7573c159b0f2
Cr-Commit-Position: refs/heads/master@{#410662}
Patch Set 1 : Merge branch 'master' into test_timeout #Patch Set 2 : Merge branch 'master' into test_timeout #Messages
Total messages: 19 (9 generated)
Patchset #1 (id:1) has been deleted
pkotwicz@chromium.org changed reviewers: + jbudorick@chromium.org
jbudorick@ can you please take a look? I wasn't able to repro the breakage on an Android One but I think that this CL will fix the test breakage
While I'm fine with the fix, 20 -> 1000 is a big jump. Could a slightly shorter timeout serve the same purpose?
Ok, lets try 100ms The goal of the timeout is that the timeout is long enough that the HTTP requests to the EmbeddedTestServer have time to complete.
lgtm On 2016/08/08 23:32:45, pkotwicz wrote: > Ok, lets try 100ms sgtm > > The goal of the timeout is that the timeout is long enough that the HTTP > requests to the EmbeddedTestServer have time to complete. Makes sense.
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/09 03:46:03, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... beware that I'm not an owner here.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Speculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester BUG=635624 ========== to ========== Speculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester BUG=635624 TBR=dfalcantara ==========
pkotwicz@chromium.org changed reviewers: + dfalcantara@chromium.org
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Speculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester BUG=635624 TBR=dfalcantara ========== to ========== Speculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester BUG=635624 TBR=dfalcantara ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Speculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester BUG=635624 TBR=dfalcantara ========== to ========== Speculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester BUG=635624 TBR=dfalcantara Committed: https://crrev.com/dab69e22fde245ba5fb7b430e26f7573c159b0f2 Cr-Commit-Position: refs/heads/master@{#410662} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/dab69e22fde245ba5fb7b430e26f7573c159b0f2 Cr-Commit-Position: refs/heads/master@{#410662} |
