Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2226903002: Speculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester (Closed)

Created:
4 years, 4 months ago by pkotwicz
Modified:
4 years, 4 months ago
Reviewers:
jbudorick, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for TestWebApkInstaller.Success on Lollipop Low-end Tester BUG=635624 TBR=dfalcantara Committed: https://crrev.com/dab69e22fde245ba5fb7b430e26f7573c159b0f2 Cr-Commit-Position: refs/heads/master@{#410662}

Patch Set 1 : Merge branch 'master' into test_timeout #

Patch Set 2 : Merge branch 'master' into test_timeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/webapk/webapk_installer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
pkotwicz
jbudorick@ can you please take a look? I wasn't able to repro the breakage on ...
4 years, 4 months ago (2016-08-08 22:16:01 UTC) #3
jbudorick
While I'm fine with the fix, 20 -> 1000 is a big jump. Could a ...
4 years, 4 months ago (2016-08-08 22:34:51 UTC) #4
pkotwicz
Ok, lets try 100ms The goal of the timeout is that the timeout is long ...
4 years, 4 months ago (2016-08-08 23:32:45 UTC) #5
jbudorick
lgtm On 2016/08/08 23:32:45, pkotwicz wrote: > Ok, lets try 100ms sgtm > > The ...
4 years, 4 months ago (2016-08-08 23:33:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226903002/40001
4 years, 4 months ago (2016-08-09 03:46:03 UTC) #8
jbudorick
On 2016/08/09 03:46:03, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 4 months ago (2016-08-09 03:47:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/233519)
4 years, 4 months ago (2016-08-09 03:51:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226903002/40001
4 years, 4 months ago (2016-08-09 13:43:57 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-09 14:27:52 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 14:29:27 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dab69e22fde245ba5fb7b430e26f7573c159b0f2
Cr-Commit-Position: refs/heads/master@{#410662}

Powered by Google App Engine
This is Rietveld 408576698