Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: runtime/vm/instructions_dbc.h

Issue 2226893002: Optimize AOT's switchable calls for the monomorphic case. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_arm_test.cc ('k') | runtime/vm/instructions_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_dbc.h
diff --git a/runtime/vm/instructions_dbc.h b/runtime/vm/instructions_dbc.h
index 5eb0c6e5bf82af7df5b61430fde80c92272550d4..6db52052bc284427f4bc1694db642ab574b1faca 100644
--- a/runtime/vm/instructions_dbc.h
+++ b/runtime/vm/instructions_dbc.h
@@ -98,19 +98,24 @@ class NativeCallPattern : public ValueObject {
};
-// Instance call that can switch from an IC call to a megamorphic call
+// Instance call that can switch between a direct monomorphic call, an IC call,
+// and a megamorphic call.
+// load guarded cid load ICData load MegamorphicCache
+// load monomorphic target <-> load ICLookup stub -> load MMLookup stub
+// call target.entry call stub.entry call stub.entry
class SwitchableCallPattern : public ValueObject {
public:
SwitchableCallPattern(uword pc, const Code& code);
- RawObject* cache() const;
- void SetCache(const MegamorphicCache& cache) const;
- void SetLookupStub(const Code& stub) const;
+ RawObject* data() const;
+ RawCode* target() const;
+ void SetData(const Object& data) const;
+ void SetTarget(const Code& target) const;
private:
const ObjectPool& object_pool_;
- intptr_t cache_pool_index_;
- intptr_t stub_pool_index_;
+ intptr_t data_pool_index_;
+ intptr_t target_pool_index_;
DISALLOW_COPY_AND_ASSIGN(SwitchableCallPattern);
};
« no previous file with comments | « runtime/vm/instructions_arm_test.cc ('k') | runtime/vm/instructions_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698