Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2226883002: MD Settings: Fix missing yellow rectangle highlighting. (Closed)

Created:
4 years, 4 months ago by dpapad
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix missing yellow rectangle highlighting. BUG=635409 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0f4f58077e1226254d3eb0c794e4c6876951df07 Cr-Commit-Position: refs/heads/master@{#410864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/resources/settings/search_settings.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dpapad
4 years, 4 months ago (2016-08-08 21:38:55 UTC) #3
dpapad
On 2016/08/08 at 21:38:55, dpapad wrote: > Friendly ping.
4 years, 4 months ago (2016-08-09 21:05:44 UTC) #4
Dan Beam
lgtm
4 years, 4 months ago (2016-08-09 21:55:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226883002/1
4 years, 4 months ago (2016-08-09 22:02:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 23:18:49 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 23:19:57 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0f4f58077e1226254d3eb0c794e4c6876951df07
Cr-Commit-Position: refs/heads/master@{#410864}

Powered by Google App Engine
This is Rietveld 408576698