third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp - Issue 2226863003: [DevTools] Reduce API surface of String16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

index 0a8e6e1e48933605b0349b59f902895ac09a1b6b..031bce38906d6f597135cd79d0a816e7c8024938 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

@@ -256,9 +256,9 @@ String16 V8StackTraceImpl::toString() const

stackTrace.append(" (");

stackTrace.append(frame.sourceURL());

stackTrace.append(':');

- stackTrace.appendNumber(frame.lineNumber());

+ stackTrace.append(String16::fromInteger(frame.lineNumber()));

stackTrace.append(':');

- stackTrace.appendNumber(frame.columnNumber());

+ stackTrace.append(String16::fromInteger(frame.columnNumber()));

stackTrace.append(')');

}

return stackTrace.toString();