Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
index f5898b4a9068e174693006b0fc80b7b195e11584..009ffd129a7159e92677068cdc3847ce6aeb980a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
@@ -95,12 +95,12 @@ int V8Debugger::contextId(v8::Local<v8::Context> context)
if (dataString.isEmpty())
return 0;
size_t commaPos = dataString.find(",");
- if (commaPos == kNotFound)
+ if (commaPos == String16::kNotFound)
return 0;
size_t commaPos2 = dataString.find(",", commaPos + 1);
- if (commaPos2 == kNotFound)
+ if (commaPos2 == String16::kNotFound)
return 0;
- return dataString.substring(commaPos + 1, commaPos2 - commaPos - 1).toInt();
+ return dataString.substring(commaPos + 1, commaPos2 - commaPos - 1).toInteger();
}
// static
@@ -113,9 +113,9 @@ int V8Debugger::getGroupId(v8::Local<v8::Context> context)
if (dataString.isEmpty())
return 0;
size_t commaPos = dataString.find(",");
- if (commaPos == kNotFound)
+ if (commaPos == String16::kNotFound)
return 0;
- return dataString.substring(0, commaPos).toInt();
+ return dataString.substring(0, commaPos).toInteger();
}
void V8Debugger::getCompiledScripts(int contextGroupId, std::vector<std::unique_ptr<V8DebuggerScript>>& result)

Powered by Google App Engine
This is Rietveld 408576698