Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h b/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h
index ba1d08047aa6bf3b268add30f6bc58fac0013ab4..fe30a4e9000c93599c31a38d751526ef2647384e 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h
+++ b/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h
@@ -83,8 +83,8 @@ struct ValueConversions<double> {
};
template<>
-struct ValueConversions<String> {
- static String parse(protocol::Value* value, ErrorSupport* errors)
+struct ValueConversions<InspectorProtocolConvenienceStringType> {
+ static InspectorProtocolConvenienceStringType parse(protocol::Value* value, ErrorSupport* errors)
{
String16 result;
bool success = value ? value->asString(&result) : false;
@@ -93,7 +93,7 @@ struct ValueConversions<String> {
return result;
}
- static std::unique_ptr<protocol::Value> serialize(const String& value)
+ static std::unique_ptr<protocol::Value> serialize(const InspectorProtocolConvenienceStringType& value)
{
return StringValue::create(value);
}

Powered by Google App Engine
This is Rietveld 408576698