third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp - Issue 2226863003: [DevTools] Reduce API surface of String16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Array.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Maybe.h » ('j') | third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp b/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

index 8f154f42ac286f04d1d712d44aa3c8d527c659e9..86ac0582eaf4beb1ee07ca8c4c9ce0119808b921 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

+++ b/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

@@ -154,7 +154,7 @@ void UberDispatcher::dispatch(const String16& message)

return;

size_t dotIndex = method.find(".");

- if (dotIndex == kNotFound) {

+ if (dotIndex == String16::kNotFound) {

reportProtocolError(m_frontendChannel, callId, DispatcherBase::MethodNotFound, "'" + method + "' wasn't found", nullptr);

return;

}