third_party/WebKit/Source/core/inspector/ThreadDebugger.h - Issue 2226863003: [DevTools] Reduce API surface of String16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wrong vector usage Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

index 3839abb2e6ecbb96c20c432a0345c278a330369e..07993bc31452676f69552e82537231a09477ac1e 100644

--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

@@ -43,7 +43,7 @@ public:

void allAsyncTasksCanceled();

void asyncTaskStarted(void* task);

void asyncTaskFinished(void* task);

- unsigned promiseRejected(v8::Local<v8::Context>, const String16& errorMessage, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation>);

+ unsigned promiseRejected(v8::Local<v8::Context>, const String& errorMessage, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation>);

void promiseRejectionRevoked(v8::Local<v8::Context>, unsigned promiseRejectionId);

protected: