Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
index 84bcc3d6e54df6d0d9eb67e53803ad062d12ce3f..71342352b84982f95bed843545a1c65f993100bc 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
@@ -84,7 +84,7 @@ private:
if (value->IsSymbolObject())
return append(v8::Local<v8::SymbolObject>::Cast(value)->ValueOf());
if (value->IsNumberObject()) {
- m_builder.appendNumber(v8::Local<v8::NumberObject>::Cast(value)->ValueOf());
+ m_builder.append(protocol::string16FromDoublePrecision6(v8::Local<v8::NumberObject>::Cast(value)->ValueOf()));
return true;
}
if (value->IsBooleanObject()) {
@@ -258,7 +258,7 @@ void V8ConsoleMessage::reportToFrontend(protocol::Runtime::Frontend* frontend, V
.setText(exception ? m_message : m_detailedMessage)
.setLineNumber(m_lineNumber ? m_lineNumber - 1 : 0)
.setColumnNumber(m_columnNumber ? m_columnNumber - 1 : 0)
- .setScriptId(m_scriptId ? String16::fromInteger(m_scriptId) : String16())
+ .setScriptId(m_scriptId ? protocol::string16FromInteger(m_scriptId) : String16())
.build();
if (!m_url.isEmpty())
details->setUrl(m_url);

Powered by Google App Engine
This is Rietveld 408576698