[DevTools] Reduce API surface of String16.

third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8Console.h"
 
 #include "platform/inspector_protocol/Platform.h"
 #include "platform/inspector_protocol/String16.h"
 #include "platform/v8_inspector/InjectedScript.h"
 #include "platform/v8_inspector/InspectedContext.h"
@@ skipping 342 matching lines @@
 
 void V8Console::countCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     ConsoleHelper helper(info);
 
     String16 title = helper.firstArgToString(String16());
     String16 identifier;
     if (title.isEmpty()) {
         std::unique_ptr<V8StackTraceImpl> stackTrace = V8StackTraceImpl::capture(nullptr, 0, 1);
         if (stackTrace)
-            identifier = stackTrace->topSourceURL() + ":" + String16::fromInteger(stackTrace->topLineNumber());
+            identifier = stackTrace->topSourceURL() + ":" + protocol::string16FromInteger(stackTrace->topLineNumber());
     } else {
         identifier = title + "@";
     }
 
     v8::Local<v8::Map> countMap;
     if (!helper.privateMap("V8Console#countMap").ToLocal(&countMap))
         return;
     int64_t count = helper.getIntFromMap(countMap, identifier, 0) + 1;
     helper.setIntOnMap(countMap, identifier, count);
-    helper.reportCallWithArgument(ConsoleAPIType::kCount, title + ": " + String16::fromInteger(count));
+    helper.reportCallWithArgument(ConsoleAPIType::kCount, title + ": " + protocol::string16FromInteger(count));
 }
 
 void V8Console::assertCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     ConsoleHelper helper(info);
     if (helper.firstArgToBoolean(false))
         return;
 
     std::vector<v8::Local<v8::Value>> arguments;
     for (int i = 1; i < info.Length(); ++i)
@@ skipping 48 matching lines @@
     if (V8InspectorClient* client = helper.ensureDebuggerClient()) {
         String16 protocolTitle = helper.firstArgToString("default");
         if (timelinePrefix)
             protocolTitle = "Timeline '" + protocolTitle + "'";
         client->consoleTimeEnd(protocolTitle);
 
         v8::Local<v8::Map> timeMap;
         if (!helper.privateMap("V8Console#timeMap").ToLocal(&timeMap))
             return;
         double elapsed = client->currentTimeMS() - helper.getDoubleFromMap(timeMap, protocolTitle, 0.0);
-        String16 message = protocolTitle + ": " + String16::fromDoubleFixedPrecision(elapsed, 3) + "ms";
+        String16 message = protocolTitle + ": " + protocol::string16FromDoublePrecision3(elapsed) + "ms";
         helper.reportCallWithArgument(ConsoleAPIType::kTimeEnd, message);
     }
 }
 
 void V8Console::timelineCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     ConsoleHelper(info).reportDeprecatedCall("V8Console#timeline", "'console.timeline' is deprecated. Please use 'console.time' instead.");
     timeFunction(info, true);
 }
 
@@ skipping 75 matching lines @@
             continue;
     }
     info.GetReturnValue().Set(values);
 }
 
 static void setFunctionBreakpoint(ConsoleHelper& helper, v8::Local<v8::Function> function, V8DebuggerAgentImpl::BreakpointSource source, const String16& condition, bool enable)
 {
     V8DebuggerAgentImpl* debuggerAgent = helper.debuggerAgent();
     if (!debuggerAgent)
         return;
-    String16 scriptId = String16::fromInteger(function->ScriptId());
+    String16 scriptId = protocol::string16FromInteger(function->ScriptId());
     int lineNumber = function->GetScriptLineNumber();
     int columnNumber = function->GetScriptColumnNumber();
     if (lineNumber == v8::Function::kLineOffsetNotFound || columnNumber == v8::Function::kLineOffsetNotFound)
         return;
     if (enable)
         debuggerAgent->setBreakpointAt(scriptId, lineNumber, columnNumber, source, condition);
     else
         debuggerAgent->removeBreakpointAt(scriptId, lineNumber, columnNumber, source);
 }
 
@@ skipping 274 matching lines @@
             continue;
         if (name->IsString()) {
             v8::Local<v8::Value> descriptor;
             bool success = m_global->GetOwnPropertyDescriptor(m_context, v8::Local<v8::String>::Cast(name)).ToLocal(&descriptor);
             DCHECK(success);
         }
     }
 }
 
 } // namespace blink