Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2226863002: [Third Party] Add byte_buddy java library to third_party. (Closed)

Created:
4 years, 4 months ago by mikecase (-- gone --)
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Third Party] Add byte_buddy java library to third_party. This library is a dependency for newer releases of Mockito. We need to update Junit/Mockito to get Espresso tests running which require being run with AndroidJunitRunner. BUG=620897 Committed: https://crrev.com/d2279c7d48b69d1bf7c9ce962b58afad3a2c0164 Cr-Commit-Position: refs/heads/master@{#411439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
A + third_party/byte_buddy/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/byte_buddy/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/byte_buddy/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/byte_buddy/README.chromium View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/byte_buddy/lib/byte-buddy-1.4.17.jar.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
mikecase (-- gone --)
4 years, 4 months ago (2016-08-08 20:37:46 UTC) #2
mikecase (-- gone --)
Link for why we need to add this here... https://github.com/mockito/mockito/blob/v2.0.99-beta/build.gradle#L58
4 years, 4 months ago (2016-08-08 20:39:09 UTC) #3
the real yoland
lgtm
4 years, 4 months ago (2016-08-08 22:02:41 UTC) #4
mikecase (-- gone --)
+ klobag for review of third_party This is so we can update Mockito/Junit. I emailed ...
4 years, 4 months ago (2016-08-08 22:11:38 UTC) #6
klobag.chromium
lgtm
4 years, 4 months ago (2016-08-10 22:20:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226863002/1
4 years, 4 months ago (2016-08-11 17:15:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/110920)
4 years, 4 months ago (2016-08-11 17:33:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226863002/1
4 years, 4 months ago (2016-08-11 18:34:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/276198)
4 years, 4 months ago (2016-08-11 19:59:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226863002/1
4 years, 4 months ago (2016-08-11 21:38:40 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 23:34:51 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 23:36:24 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2279c7d48b69d1bf7c9ce962b58afad3a2c0164
Cr-Commit-Position: refs/heads/master@{#411439}

Powered by Google App Engine
This is Rietveld 408576698