New resources for the mirror preview UI

New resources for the mirror preview UI

BUG=358265

[guohui, 2014-04-02 21:11:22]

Hey,

could you please review the CL?

Thanks,

Hui

[oshima, 2014-04-02 22:07:29]

lgtm

[guohui, 2014-04-02 23:18:49]

The CQ bit was checked by guohui@chromium.org

[commit-bot: I haz the power, 2014-04-02 23:20:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/222683004/20001

[commit-bot: I haz the power, 2014-04-02 23:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 23:20:40]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file
chrome/app/theme/default_200_percent/common/carrot_blue.png.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[oshima, 2014-04-03 17:24:45]

On 2014/04/02 23:20:40, I haz the power (commit-bot) wrote:
> Failed to request the patch to try. Please note that binary files are still
> unsupported at the moment, this is being worked on.
> 
> Thanks for your patience.
> 
> Transient error: Can't process patch for file
> chrome/app/theme/default_200_percent/common/carrot_blue.png.
> Binary file is empty. Maybe the file wasn't uploaded in the first place?

you need to dcommit png files.

[guohui, 2014-04-03 17:45:42]

On 2014/04/03 17:24:45, oshima wrote:
> On 2014/04/02 23:20:40, I haz the power (commit-bot) wrote:
> > Failed to request the patch to try. Please note that binary files are still
> > unsupported at the moment, this is being worked on.
> > 
> > Thanks for your patience.
> > 
> > Transient error: Can't process patch for file
> > chrome/app/theme/default_200_percent/common/carrot_blue.png.
> > Binary file is empty. Maybe the file wasn't uploaded in the first place?
> 
> you need to dcommit png files.

yup, i already dcommitted, for some reason the CL is not updated, will close it
manually.

[oshima, 2014-05-10 00:15:51]

On 2014/04/03 17:45:42, guohui wrote:
> On 2014/04/03 17:24:45, oshima wrote:
> > On 2014/04/02 23:20:40, I haz the power (commit-bot) wrote:
> > > Failed to request the patch to try. Please note that binary files are
still
> > > unsupported at the moment, this is being worked on.
> > > 
> > > Thanks for your patience.
> > > 
> > > Transient error: Can't process patch for file
> > > chrome/app/theme/default_200_percent/common/carrot_blue.png.
> > > Binary file is empty. Maybe the file wasn't uploaded in the first place?
> > 
> > you need to dcommit png files.
> 
> yup, i already dcommitted, for some reason the CL is not updated, will close
it
> manually.

Hi, I wonder if you have had this presubmit warning when you dcommit it.

> ** Presubmit ERRORS **
> Image chrome/app/theme/default_200_percent/common/carrot_blue.png has width
32, expected to be 34

This means that the size of 2x image is not 2x of the size of 1x image. Could
you please get new image with the correct size from UX designer and land it?
(It needs to be merged to 36 branch if this feature is launching on 36.)

[guohui, 2014-05-16 20:52:49]

thanks for catching it! i ll ping our UI designer for a new image.

[guohui, 2014-05-16 20:53:05]

On 2014/05/16 20:52:49, guohui wrote:
> thanks for catching it! i ll ping our UI designer for a new image.

and i do not remember seeing presubmit error =(