Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 222683002: Add generation ID to SkPicture (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add generation ID to SkPicture This is intended to give Ganesh's LayerCache an easy item to use for caching SkPicture information.

Patch Set 1 #

Patch Set 2 : Fix Mac10.6 compiler issue #

Patch Set 3 : Fix Ubuntu compiler complaint #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -7 lines) Patch
M include/core/SkPicture.h View 1 2 5 chunks +14 lines, -5 lines 2 comments Download
M src/core/SkPicture.cpp View 1 2 10 chunks +37 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-02 18:38:01 UTC) #1
bsalomon
lgtm
6 years, 8 months ago (2014-04-02 19:16:06 UTC) #2
bsalomon
Adding reed@ for a post-review.
6 years, 8 months ago (2014-04-02 19:16:28 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-02 22:58:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/222683002/20001
6 years, 8 months ago (2014-04-02 22:58:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 23:22:33 UTC) #6
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildEverything http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Release-Trybot&number=1916
6 years, 8 months ago (2014-04-02 23:22:33 UTC) #7
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-02 23:25:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/222683002/20001
6 years, 8 months ago (2014-04-02 23:25:08 UTC) #9
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-02 23:38:10 UTC) #10
robertphillips
The CQ bit was unchecked by robertphillips@google.com
6 years, 8 months ago (2014-04-02 23:50:41 UTC) #11
robertphillips
committed as r14037
6 years, 8 months ago (2014-04-02 23:51:32 UTC) #12
reed1
6 years, 8 months ago (2014-04-07 13:16:58 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/222683002/diff/40001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/222683002/diff/40001/include/core/SkPicture.h...
include/core/SkPicture.h:204: static const uint32_t kInvalidGenID = 0;
Seems like this should be in some larger/global header, since we have the same
convention for all of our classes that use genIDs

https://codereview.chromium.org/222683002/diff/40001/include/core/SkPicture.h...
include/core/SkPicture.h:211: uint32_t getGenerationID() const;
Why not call it uniqueID() as we do in typeface?

Powered by Google App Engine
This is Rietveld 408576698