Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2226813002: SkLiteDL: control reuse by a single parameter (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkLiteDL: control reuse by a single parameter This simply caps the number of times a display list can be reused. As this number goes up, the average amount of memory we cache goes up and the expected number of mallocs per SkLiteDL::New() goes down. This strategy does not need a hard-coded cap on how many display lists to cache, or how big they can grow. TBR=herb@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2226813002 Committed: https://skia.googlesource.com/skia/+/765b6e654802b770784becf3f53e5bd8beea4c9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M src/core/SkLiteDL.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkLiteDL.cpp View 3 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mtklein
4 years, 4 months ago (2016-08-08 18:53:43 UTC) #6
mtklein_C
4 years, 4 months ago (2016-08-08 18:54:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226813002/1
4 years, 4 months ago (2016-08-08 18:54:08 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 19:23:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/765b6e654802b770784becf3f53e5bd8beea4c9d

Powered by Google App Engine
This is Rietveld 408576698