Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2226803003: Replace SloppyBlockFunctionMap::Vector with linked list through SloppyBlockFunctionStatement (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace SloppyBlockFunctionMap::Vector with linked list through SloppyBlockFunctionStatement BUG=v8:5209 Committed: https://crrev.com/b1d53a154993289bca4322aad24cf8e415a8940e Cr-Commit-Position: refs/heads/master@{#38460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/ast/ast.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/ast/scopes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/scopes.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-08 18:56:58 UTC) #2
adamk
lgtm
4 years, 4 months ago (2016-08-08 19:52:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226803003/1
4 years, 4 months ago (2016-08-08 20:11:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:34:05 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:39:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1d53a154993289bca4322aad24cf8e415a8940e
Cr-Commit-Position: refs/heads/master@{#38460}

Powered by Google App Engine
This is Rietveld 408576698