Remove the android_isolate_path option from LocalGTestTest.

scripts/slave/recipe_modules/chromium_tests/steps.py

Index: scripts/slave/recipe_modules/chromium_tests/steps.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py
index 3e55c4186348c49ea67187f583439ecf8c3f3cc8..4358431e2f6770b78c653e19c2913bf90407bbc1 100644
--- a/scripts/slave/recipe_modules/chromium_tests/steps.py
+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py
@@ -227,7 +227,7 @@ class ScriptTest(Test):  # pylint: disable=W0232
 
 class LocalGTestTest(Test):
   def __init__(self, name, args=None, target_name=None, use_isolate=False,
-               revision=None, webkit_revision=None, android_isolate_path=None,
+               revision=None, webkit_revision=None,
                android_shard_timeout=None, android_tool=None,
                override_compile_targets=None, override_isolate_target=None,
                use_xvfb=True, **runtest_kwargs):
@@ -258,7 +258,6 @@ class LocalGTestTest(Test):
     self._use_isolate = use_isolate
     self._revision = revision
     self._webkit_revision = webkit_revision
-    self._android_isolate_path = android_isolate_path
     self._android_shard_timeout = android_shard_timeout
     self._android_tool = android_tool
     self._override_compile_targets = override_compile_targets
@@ -322,9 +321,6 @@ class LocalGTestTest(Test):
       # TODO(sergiyb): Figure out if we can reuse isolate module for running
       # isolated Android tests, rather than using custom solution in Android

[Nico, 2016/08/09 16:32:51]

does this comment still makes sense? (i think so, but not sure)

[jbudorick, 2016/08/09 16:39:26]

I'm not sure. We're not even using isolate module in the non-android case, but
it'd still be nice to not have separate android paths in here.

+sergiyb: what was your original intention w/ this TODO?

[Sergiy Byelozyorov, 2016/08/09 16:56:40]

I think someone actually fixed it and did not remove this comment, see original
CL: https://codereview.chromium.org/892463002. There we were passing
isolate_file_path to the test laucnher. OTH, I am not 100% sure that this logic
wasn't just moved elsewhere. I'd search for the CL that removed
isolate_file_path to see whether the author removed it for good or actually just
moved it.

       # test launcher.
-      if self._android_isolate_path:
-        isolate_path = api.path['checkout'].join(self._android_isolate_path)
-        kwargs['isolate_file_path'] = isolate_path

[jbudorick, 2016/08/09 17:01:25]

sergiyb: ...are you referring to this?

[Sergiy Byelozyorov, 2016/08/09 18:22:49]

Ahem. Gotta look 10cm to the right (in a side-by-side diff) once in a while :-).
Yes, I mean this. I think this comment can now be removed.

[jbudorick, 2016/08/09 19:12:52]

Great, thanks. Removed the TODO.

       kwargs['json_results_file'] = gtest_results_file
       kwargs['flakiness_dashboard'] = 'test-results.appspot.com'
       kwargs['shard_timeout'] = self._android_shard_timeout