Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2226753002: [wasm] external serialization APIs (Closed)

Created:
4 years, 4 months ago by Mircea Trofin
Modified:
4 years, 4 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] external serialization APIs V8 APIs for wasm serialization/deserialization. BUG=v8:5072 Committed: https://crrev.com/5de4722278e6a89c787e2ae951d9c2a0fb4a9ef8 Cr-Commit-Position: refs/heads/master@{#38455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +20 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Mircea Trofin
4 years, 4 months ago (2016-08-08 16:50:37 UTC) #7
bradnelson
lgtm Any way to test this on the v8 side?
4 years, 4 months ago (2016-08-08 17:12:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226753002/1
4 years, 4 months ago (2016-08-08 18:17:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 18:19:07 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5de4722278e6a89c787e2ae951d9c2a0fb4a9ef8 Cr-Commit-Position: refs/heads/master@{#38455}
4 years, 4 months ago (2016-08-08 18:20:02 UTC) #14
Mircea Trofin
4 years, 4 months ago (2016-08-08 18:22:00 UTC) #15
Message was sent while issue was closed.
On 2016/08/08 17:12:27, bradnelson wrote:
> lgtm
> Any way to test this on the v8 side?

At the moment, these are just wrappers. The tests come with the
other CL that that TODOs reference.

Powered by Google App Engine
This is Rietveld 408576698