Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2226733004: [Android] Add an about flag for Download Manager UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [Android] Add an about flag for Download Manager UI Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1268 matching lines...) Expand 10 before | Expand all | Expand 10 after
1279 {"reset-app-list-install-state", 1279 {"reset-app-list-install-state",
1280 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_NAME, 1280 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_NAME,
1281 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_DESCRIPTION, 1281 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_DESCRIPTION,
1282 kOsMac | kOsWin | kOsLinux, 1282 kOsMac | kOsWin | kOsLinux,
1283 SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)}, 1283 SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)},
1284 #endif 1284 #endif
1285 #if defined(OS_ANDROID) 1285 #if defined(OS_ANDROID)
1286 {"enable-all-bookmarks-view", IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_NAME, 1286 {"enable-all-bookmarks-view", IDS_FLAGS_ENABLE_ALL_BOOKMARKS_VIEW_NAME,
1287 IDS_FLAGS_SHOW_ALL_BOOKMARKS_VIEW_DESCRIPTION, kOsAndroid, 1287 IDS_FLAGS_SHOW_ALL_BOOKMARKS_VIEW_DESCRIPTION, kOsAndroid,
1288 FEATURE_VALUE_TYPE(chrome::android::kAllBookmarksFeature)}, 1288 FEATURE_VALUE_TYPE(chrome::android::kAllBookmarksFeature)},
1289 {"enable-downloads-ui", IDS_FLAGS_ENABLE_DOWNLOADS_UI_NAME,
1290 IDS_FLAGS_ENABLE_DOWNLOADS_UI_DESCRIPTION, kOsAndroid,
1291 FEATURE_VALUE_TYPE(chrome::android::kDownloadsUiFeature)},
1289 {"enable-accessibility-tab-switcher", 1292 {"enable-accessibility-tab-switcher",
1290 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME, 1293 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME,
1291 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_DESCRIPTION, kOsAndroid, 1294 IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_DESCRIPTION, kOsAndroid,
1292 SINGLE_VALUE_TYPE(switches::kEnableAccessibilityTabSwitcher)}, 1295 SINGLE_VALUE_TYPE(switches::kEnableAccessibilityTabSwitcher)},
1293 {"enable-physical-web", IDS_FLAGS_ENABLE_PHYSICAL_WEB_NAME, 1296 {"enable-physical-web", IDS_FLAGS_ENABLE_PHYSICAL_WEB_NAME,
1294 IDS_FLAGS_ENABLE_PHYSICAL_WEB_DESCRIPTION, kOsAndroid, 1297 IDS_FLAGS_ENABLE_PHYSICAL_WEB_DESCRIPTION, kOsAndroid,
1295 FEATURE_VALUE_TYPE(chrome::android::kPhysicalWebFeature)}, 1298 FEATURE_VALUE_TYPE(chrome::android::kPhysicalWebFeature)},
1296 #endif 1299 #endif
1297 {"enable-zero-copy", IDS_FLAGS_ZERO_COPY_NAME, 1300 {"enable-zero-copy", IDS_FLAGS_ZERO_COPY_NAME,
1298 IDS_FLAGS_ZERO_COPY_DESCRIPTION, kOsAll, 1301 IDS_FLAGS_ZERO_COPY_DESCRIPTION, kOsAll,
(...skipping 743 matching lines...) Expand 10 before | Expand all | Expand 10 after
2042 IDS_ENABLE_INTENT_PICKER_DESCRIPTION, kOsCrOS, 2045 IDS_ENABLE_INTENT_PICKER_DESCRIPTION, kOsCrOS,
2043 SINGLE_VALUE_TYPE(switches::kEnableIntentPicker)}, 2046 SINGLE_VALUE_TYPE(switches::kEnableIntentPicker)},
2044 {"files-quick-view", IDS_FLAGS_FILES_QUICK_VIEW_NAME, 2047 {"files-quick-view", IDS_FLAGS_FILES_QUICK_VIEW_NAME,
2045 IDS_FLAGS_FILES_QUICK_VIEW_DESCRIPTION, kOsCrOS, 2048 IDS_FLAGS_FILES_QUICK_VIEW_DESCRIPTION, kOsCrOS,
2046 ENABLE_DISABLE_VALUE_TYPE(chromeos::switches::kEnableFilesQuickView, 2049 ENABLE_DISABLE_VALUE_TYPE(chromeos::switches::kEnableFilesQuickView,
2047 chromeos::switches::kDisableFilesQuickView)}, 2050 chromeos::switches::kDisableFilesQuickView)},
2048 {"quick-unlock-pin", IDS_FLAGS_QUICK_UNLOCK_PIN, 2051 {"quick-unlock-pin", IDS_FLAGS_QUICK_UNLOCK_PIN,
2049 IDS_FLAGS_QUICK_UNLOCK_PIN_DESCRIPTION, kOsCrOS, 2052 IDS_FLAGS_QUICK_UNLOCK_PIN_DESCRIPTION, kOsCrOS,
2050 FEATURE_VALUE_TYPE(features::kQuickUnlockPin)}, 2053 FEATURE_VALUE_TYPE(features::kQuickUnlockPin)},
2051 #endif // defined(OS_CHROMEOS) 2054 #endif // defined(OS_CHROMEOS)
2052 // NOTE: Adding new command-line switches requires adding corresponding 2055 // NOTE: Adding new command-line switches requires adding corresponding
gone 2016/08/09 21:00:29 nit: Remove extra space
2053 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2056 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2054 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2057 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2055 }; 2058 };
2056 2059
2057 class FlagsStateSingleton { 2060 class FlagsStateSingleton {
2058 public: 2061 public:
2059 FlagsStateSingleton() 2062 FlagsStateSingleton()
2060 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2063 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2061 ~FlagsStateSingleton() {} 2064 ~FlagsStateSingleton() {}
2062 2065
2063 static FlagsStateSingleton* GetInstance() { 2066 static FlagsStateSingleton* GetInstance() {
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
2232 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2235 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2233 2236
2234 const FeatureEntry* GetFeatureEntries(size_t* count) { 2237 const FeatureEntry* GetFeatureEntries(size_t* count) {
2235 *count = arraysize(kFeatureEntries); 2238 *count = arraysize(kFeatureEntries);
2236 return kFeatureEntries; 2239 return kFeatureEntries;
2237 } 2240 }
2238 2241
2239 } // namespace testing 2242 } // namespace testing
2240 2243
2241 } // namespace about_flags 2244 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698