Color: Clean up color profile handling for layout tests

content/shell/renderer/layout_test/layout_test_content_renderer_client.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/layout_test/layout_test_content_renderer_client.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "components/test_runner/mock_credential_manager_client.h"
@@ skipping 14 matching lines @@
 #include "content/shell/renderer/layout_test/layout_test_render_thread_observer.h"
 #include "content/shell/renderer/layout_test/test_media_stream_renderer_factory.h"
 #include "content/shell/renderer/shell_render_view_observer.h"
 #include "content/test/mock_webclipboard_impl.h"
 #include "ppapi/shared_impl/ppapi_switches.h"
 #include "third_party/WebKit/public/platform/WebMediaStreamCenter.h"
 #include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerClient.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "third_party/WebKit/public/web/WebTestingSupport.h"
 #include "third_party/WebKit/public/web/WebView.h"
+#include "ui/gfx/icc_profile.h"
 #include "v8/include/v8.h"
 
 using blink::WebAudioDevice;
 using blink::WebClipboard;
 using blink::WebFrame;
 using blink::WebLocalFrame;
 using blink::WebMIDIAccessor;
 using blink::WebMIDIAccessorClient;
 using blink::WebMediaStreamCenter;
 using blink::WebMediaStreamCenterClient;
@@ skipping 151 matching lines @@
 std::unique_ptr<MediaStreamRendererFactory>
 LayoutTestContentRendererClient::CreateMediaStreamRendererFactory() {
 #if defined(ENABLE_WEBRTC)
   return std::unique_ptr<MediaStreamRendererFactory>(
       new TestMediaStreamRendererFactory());
 #else
   return nullptr;
 #endif
 }
 
+std::unique_ptr<gfx::ICCProfile>
+LayoutTestContentRendererClient::GetImageDecodeColorProfile() {

[ccameron, 2016/08/09 07:11:08]

An alternative TODO here would be to change all platforms to use a single color
profile.

That will require a rebaseline of a bazillion tests, but may be the right thing
to do.

[hubbe, 2016/08/09 16:59:54]

Why is it that the code behaves differently when you have no icc profile or when
 you have an sRGB profile anyways?

[Dirk Pranke, 2016/08/09 20:32:31]

Yup, I'd say that's the right thing to do, so maybe update the TODO accordingly?

+#if defined(OS_WIN)
+  // TODO(ccameron): Find out what color profile is currently preset on Windows
+  // test machines, and return that here.
+  return nullptr;
+#elif defined(OS_MACOSX)
+  // Layout tests on Mac expect a generic RGB color profile.
+  return base::WrapUnique(new gfx::ICCProfile(gfx::ICCProfile::FromCGColorSpace(
+      CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB))));
+#else
+  // All other platforms expect no color profile to have been specified.
+  return base::WrapUnique(new gfx::ICCProfile());
+#endif
+}
+
 void LayoutTestContentRendererClient::DidInitializeWorkerContextOnWorkerThread(
     v8::Local<v8::Context> context) {
   blink::WebTestingSupport::injectInternalsObject(context);
 }
 
 }  // namespace content