src/x64/codegen-x64.cc - Issue 22267005: Use StackArgumenstAccessor and kPCOnStackSize/kFPOnStackSize to compute stack address/operand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 22267005: Use StackArgumenstAccessor and kPCOnStackSize/kFPOnStackSize to compute stack address/operand (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased with master and refactored newly-introduced GenerateFastApiCall with StackArgumentsAccessor Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/codegen-x64.cc

diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc

index 24773c2595d1303aac57cacd10cad243a868e9e0..52397f4c36620537ebf35758083a09482a123ff5 100644

--- a/src/x64/codegen-x64.cc

+++ b/src/x64/codegen-x64.cc

@@ -746,7 +746,6 @@ void Code::PatchPlatformCodeAge(byte* sequence,

Operand StackArgumentsAccessor::GetArgumentOperand(int index) {

ASSERT(index >= 0);

- ASSERT(base_reg_.is(rsp) || base_reg_.is(rbp));

int receiver = (receiver_mode_ == ARGUMENTS_CONTAIN_RECEIVER) ? 1 : 0;

int displacement_to_last_argument = base_reg_.is(rsp) ?

kPCOnStackSize : kFPOnStackSize + kPCOnStackSize;

« src/x64/code-stubs-x64.cc ('K') | « src/x64/codegen-x64.h ('k') | src/x64/frames-x64.h » ('j') | src/x64/macro-assembler-x64.cc » ('J')