src/x64/builtins-x64.cc - Issue 22267005: Use StackArgumenstAccessor and kPCOnStackSize/kFPOnStackSize to compute stack address/operand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 22267005: Use StackArgumenstAccessor and kPCOnStackSize/kFPOnStackSize to compute stack address/operand (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased with master and refactored newly-introduced GenerateFastApiCall with StackArgumentsAccessor Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index 4730ed14d59142c9fd3d532de071ccd4a1a8c99b..33ff31b09c74cb622bd2d25a5644d7f4c0353d86 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -944,9 +944,9 @@ void Builtins::Generate_FunctionApply(MacroAssembler* masm) {

// rbp[16] : function arguments

// rbp[24] : receiver

// rbp[32] : function

- static const int kArgumentsOffset = 2 * kPointerSize;

- static const int kReceiverOffset = 3 * kPointerSize;

- static const int kFunctionOffset = 4 * kPointerSize;

+ static const int kArgumentsOffset = kFPOnStackSize + kPCOnStackSize;

+ static const int kReceiverOffset = kArgumentsOffset + kPointerSize;

+ static const int kFunctionOffset = kReceiverOffset + kPointerSize;

__ push(Operand(rbp, kFunctionOffset));

__ push(Operand(rbp, kArgumentsOffset));

« no previous file with comments | « no previous file | src/x64/code-stubs-x64.cc » ('j') | src/x64/code-stubs-x64.cc » ('J')