Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 22267005: Use StackArgumenstAccessor and kPCOnStackSize/kFPOnStackSize to compute stack address/operand (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased with bleeding_edge Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/codegen-x64.h ('k') | src/x64/frames-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 729 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 i < kNoCodeAgeSequenceLength - Assembler::kShortCallInstructionLength; 740 i < kNoCodeAgeSequenceLength - Assembler::kShortCallInstructionLength;
741 i++) { 741 i++) {
742 patcher.masm()->nop(); 742 patcher.masm()->nop();
743 } 743 }
744 } 744 }
745 } 745 }
746 746
747 747
748 Operand StackArgumentsAccessor::GetArgumentOperand(int index) { 748 Operand StackArgumentsAccessor::GetArgumentOperand(int index) {
749 ASSERT(index >= 0); 749 ASSERT(index >= 0);
750 ASSERT(base_reg_.is(rsp) || base_reg_.is(rbp));
751 int receiver = (receiver_mode_ == ARGUMENTS_CONTAIN_RECEIVER) ? 1 : 0; 750 int receiver = (receiver_mode_ == ARGUMENTS_CONTAIN_RECEIVER) ? 1 : 0;
752 int displacement_to_last_argument = base_reg_.is(rsp) ? 751 int displacement_to_last_argument = base_reg_.is(rsp) ?
753 kPCOnStackSize : kFPOnStackSize + kPCOnStackSize; 752 kPCOnStackSize : kFPOnStackSize + kPCOnStackSize;
754 displacement_to_last_argument += extra_displacement_to_last_argument_; 753 displacement_to_last_argument += extra_displacement_to_last_argument_;
755 if (argument_count_reg_.is(no_reg)) { 754 if (argument_count_reg_.is(no_reg)) {
756 // argument[0] is at base_reg_ + displacement_to_last_argument + 755 // argument[0] is at base_reg_ + displacement_to_last_argument +
757 // (argument_count_immediate_ + receiver - 1) * kPointerSize. 756 // (argument_count_immediate_ + receiver - 1) * kPointerSize.
758 ASSERT(argument_count_immediate_ + receiver > 0); 757 ASSERT(argument_count_immediate_ + receiver > 0);
759 return Operand(base_reg_, displacement_to_last_argument + 758 return Operand(base_reg_, displacement_to_last_argument +
760 (argument_count_immediate_ + receiver - 1 - index) * kPointerSize); 759 (argument_count_immediate_ + receiver - 1 - index) * kPointerSize);
761 } else { 760 } else {
762 // argument[0] is at base_reg_ + displacement_to_last_argument + 761 // argument[0] is at base_reg_ + displacement_to_last_argument +
763 // argument_count_reg_ * times_pointer_size + (receiver - 1) * kPointerSize. 762 // argument_count_reg_ * times_pointer_size + (receiver - 1) * kPointerSize.
764 return Operand(base_reg_, argument_count_reg_, times_pointer_size, 763 return Operand(base_reg_, argument_count_reg_, times_pointer_size,
765 displacement_to_last_argument + (receiver - 1 - index) * kPointerSize); 764 displacement_to_last_argument + (receiver - 1 - index) * kPointerSize);
766 } 765 }
767 } 766 }
768 767
769 768
770 } } // namespace v8::internal 769 } } // namespace v8::internal
771 770
772 #endif // V8_TARGET_ARCH_X64 771 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/codegen-x64.h ('k') | src/x64/frames-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698