Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2226673002: X87: [stubs] Convert GrowElementsStub to TurboFan. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Convert GrowElementsStub to TurboFan. port eb841269235e6b438b75930878a8cb3ca745014c (r38371) original commit message: One caveat: the Crankshaft stub used to preserve callee-clobbered double registers, which is contrary to any real platform ABI that we support. Since the only current use of this stub is in Crankshaft, the instruction there now must be marked as double-clobbering. This might result in a small performance regression. However, when this stub is eventually used in TF-generated code, it will be called from deferred code that can save doubles only on the rarely-taken path... something that Crankshaft can't do. BUG= Committed: https://crrev.com/978edb2421b57be0a7e3c2f9eecc641f39a1480b Cr-Commit-Position: refs/heads/master@{#38465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-08 09:33:48 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-09 02:35:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226673002/1
4 years, 4 months ago (2016-08-09 02:38:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 06:45:48 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 06:49:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/978edb2421b57be0a7e3c2f9eecc641f39a1480b
Cr-Commit-Position: refs/heads/master@{#38465}

Powered by Google App Engine
This is Rietveld 408576698