Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: components/content_settings/core/common/content_settings_pattern_unittest.cc

Issue 2226643002: Add metrics for schemes of content setting exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/common/content_settings_pattern_unittest.cc
diff --git a/components/content_settings/core/common/content_settings_pattern_unittest.cc b/components/content_settings/core/common/content_settings_pattern_unittest.cc
index 38125c49fc47152adee3113823403b4d37b53c5f..9ca587746c6844aecca17f43d469276f266b17fa 100644
--- a/components/content_settings/core/common/content_settings_pattern_unittest.cc
+++ b/components/content_settings/core/common/content_settings_pattern_unittest.cc
@@ -808,4 +808,22 @@ TEST(ContentSettingsPatternTest, MigrateFromDomainToOrigin) {
ContentSettingsPattern::FromString("https://[*.]google.com:443"),
&origin_pattern));
EXPECT_EQ("https://google.com:443", origin_pattern.ToString());
+}
+
+TEST(ContentSettingsPatternTest, Schemes) {
+ EXPECT_EQ(ContentSettingsPattern::SCHEME_HTTP,
+ Pattern("http://www.example.com").GetScheme());
+ EXPECT_EQ(ContentSettingsPattern::SCHEME_HTTPS,
+ Pattern("https://www.example.com").GetScheme());
+ EXPECT_EQ(ContentSettingsPattern::SCHEME_FILE,
+ Pattern("file:///tmp/file.html").GetScheme());
+ EXPECT_EQ(ContentSettingsPattern::SCHEME_CHROMEEXTENSION,
+ Pattern("chrome-extension://peoadpeiejnhkmpaakpnompolbglelel/")
+ .GetScheme());
+ EXPECT_EQ(ContentSettingsPattern::SCHEME_WILDCARD,
+ Pattern("192.168.0.1").GetScheme());
+ EXPECT_EQ(ContentSettingsPattern::SCHEME_WILDCARD,
+ Pattern("www.example.com").GetScheme());
+ EXPECT_EQ(ContentSettingsPattern::SCHEME_OTHER,
+ Pattern("filesystem:http://www.google.com/temporary/").GetScheme());
}
« no previous file with comments | « components/content_settings/core/common/content_settings_pattern.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698