Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: components/content_settings/core/browser/host_content_settings_map.cc

Issue 2226643002: Add metrics for schemes of content setting exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/host_content_settings_map.cc
diff --git a/components/content_settings/core/browser/host_content_settings_map.cc b/components/content_settings/core/browser/host_content_settings_map.cc
index 1805e9cd1b74760f6b71f821e12adf3522e6d18c..4ef44935b9d47291121a9cb5d07db2f9f3c86a9a 100644
--- a/components/content_settings/core/browser/host_content_settings_map.cc
+++ b/components/content_settings/core/browser/host_content_settings_map.cc
@@ -187,7 +187,7 @@ HostContentSettingsMap::HostContentSettingsMap(PrefService* prefs,
MigrateKeygenSettings();
MigrateDomainScopedSettings(false);
- RecordNumberOfExceptions();
+ RecordExceptionMetrics();
}
// static
@@ -600,7 +600,7 @@ base::WeakPtr<HostContentSettingsMap> HostContentSettingsMap::GetWeakPtr() {
return weak_ptr_factory_.GetWeakPtr();
}
-void HostContentSettingsMap::RecordNumberOfExceptions() {
+void HostContentSettingsMap::RecordExceptionMetrics() {
for (const content_settings::WebsiteSettingsInfo* info :
*content_settings::WebsiteSettingsRegistry::GetInstance()) {
ContentSettingsType content_type = info->type();
@@ -610,6 +610,17 @@ void HostContentSettingsMap::RecordNumberOfExceptions() {
GetSettingsForOneType(content_type, std::string(), &settings);
size_t num_exceptions = 0;
for (const ContentSettingPatternSource& setting_entry : settings) {
+ // Skip default settings.
+ if (setting_entry.primary_pattern == ContentSettingsPattern::Wildcard() &&
+ setting_entry.secondary_pattern ==
+ ContentSettingsPattern::Wildcard()) {
+ continue;
+ }
+
+ UMA_HISTOGRAM_ENUMERATION("ContentSettings.ExceptionScheme",
+ setting_entry.primary_pattern.GetScheme(),
+ ContentSettingsPattern::SCHEME_MAX);
+
if (setting_entry.source == "preference")
++num_exceptions;
}

Powered by Google App Engine
This is Rietveld 408576698