tools/metrics/histograms/histograms.xml - Issue 2226643002: Add metrics for schemes of content setting exceptions

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2226643002: Add metrics for schemes of content setting exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/content_settings/core/common/content_settings_pattern.h ('K') | « components/content_settings/core/common/content_settings_pattern_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 7dd4a3842746ee713a6c2e134eb3d2656a10f118..fdbeb55a25dccb7fd3ab54818bcaeb219d63e4c7 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -6555,6 +6555,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="ContentSettings.ExceptionScheme" enum="ContentSettingScheme">

+ <owner>lshang@chromium.org</owner>

+ <summary>

+ The number of different content setting exception schemes at browser start.

Ilya Sherman 2016/08/10 05:34:26 If I understand this description correctly, then I

lshang 2016/08/11 00:26:50 Done. Yeah you understand correctly, I've changed

+ </summary>

+</histogram>

Deprecated 2015-10-05 in Issue 433475. Histogram was used temorarily for

@@ -70663,6 +70670,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</enum>

+<enum name="ContentSettingScheme" type="int">

+ <int value="0" label="(wildcard)"/>

+ <int value="1" label="http"/>

+ <int value="2" label="https"/>

+ <int value="3" label="file"/>

+ <int value="4" label="chrome-extension"/>

+ <int value="5" label="(other)"/>

Ilya Sherman 2016/08/10 05:34:26 I'd recommend listing unknown/other as the first b

lshang 2016/08/11 00:26:50 Done. Moved all known schmes down to the list.

+</enum>