chrome/browser/notifications/notification_permission_infobar_delegate.h - Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_infobar_delegate.h

Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, do not show toggle for notifications Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/geolocation/geolocation_infobar_delegate_android.h ('K') | « chrome/browser/media/protected_media_identifier_infobar_delegate_android.cc ('k') | chrome/browser/notifications/notification_permission_infobar_delegate.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_permission_infobar_delegate.h

diff --git a/chrome/browser/notifications/notification_permission_infobar_delegate.h b/chrome/browser/notifications/notification_permission_infobar_delegate.h

index b2e6532797f596b29c4adca155cb6a099395e5d6..1d49e089d681345cea286fe1bd1e790603a1cbda 100644

--- a/chrome/browser/notifications/notification_permission_infobar_delegate.h

+++ b/chrome/browser/notifications/notification_permission_infobar_delegate.h

@@ -10,6 +10,8 @@

#include "base/macros.h"

#include "chrome/browser/permissions/permission_infobar_delegate.h"

+class InfoBarService;

class NotificationPermissionInfobarDelegate : public PermissionInfobarDelegate {

public:

// Creates a Notification permission infobar and delegate and adds the

@@ -21,6 +23,8 @@ class NotificationPermissionInfobarDelegate : public PermissionInfobarDelegate {

Profile* profile,

const PermissionSetCallback& callback);

+ bool ShouldShowPersistenceToggle() const override;

private:

NotificationPermissionInfobarDelegate(const GURL& requesting_frame,

bool user_gesture,