Adds support for running unittests using XCTest on iOS.

Adds support for running unittests using XCTest on iOS.

Modifies the base TestSuite to check if running under XCTest and return early
without running tests if so.  This allows XCTest to drive running the individual
tests, while still allowing the TestSuite to perform setup tasks.

BUG=635509
Committed: https://crrev.com/fc9315e90cf523b90010145980f953f86c077a51
Cr-Commit-Position: refs/heads/master@{#410698}

[rohitrao (ping after 24h), 2016-08-08 13:21:32]

rohitrao@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[rohitrao (ping after 24h), 2016-08-08 13:21:32]

I'd like to experiment with running unittests directly from xcode on iOS.  It's
possible to wrap gtests inside of an XCTest, but there are some fundamental
changes to our gtest runner that also need to be made:

1) XCTest will drive running the tests, so our base::TestSuite::Run() can't also
call RUN_ALL_TESTS().  This CL adds an early return if running in xctest mode on
iOS.

2) We still want all of the setup work that comes from TestSuite and its
subclasses, so this CL also makes sure the test suite doesn't tear itself down
before the tests finish running.

This CL is explicitly intended to be a no-op if the XCTest library has not been
injected into the app process.  Running in gtest mode is still the primary
method for running unittests.

[rohitrao (ping after 24h), 2016-08-08 13:21:44]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 13:21:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 14:17:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:17:30]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-08-08 20:48:29]

phajdan.jr@chromium.org changed reviewers:
+ mark@chromium.org

[Paweł Hajdan Jr., 2016-08-08 20:48:30]

Please get a review from another Mac expert (e.g. Mark Mentovai), and I or
another base or base/test OWNER can then stamp.

FWIW, this looks fine to me, I'd just prefer this to be reviewed by someone who
understands XCTest better.

[Mark Mentovai, 2016-08-08 20:55:44]

LGTM, as long as you promise to remove this if your experiments fail.

https://codereview.chromium.org/2226623003/diff/1/base/test/test_support_ios.mm
File base/test/test_support_ios.mm (right):

https://codereview.chromium.org/2226623003/diff/1/base/test/test_support_ios....
base/test/test_support_ios.mm:231: NSDictionary* environment = [[NSProcessInfo
processInfo] environment];
  return getenv("XCTestConfigurationFilePath") != nullptr;

is less wordy and faster

[rohitrao (ping after 24h), 2016-08-09 11:40:23]

Removing code I can do.  I'm more concerned about the case where this actually
works =)

https://codereview.chromium.org/2226623003/diff/1/base/test/test_support_ios.mm
File base/test/test_support_ios.mm (right):

https://codereview.chromium.org/2226623003/diff/1/base/test/test_support_ios....
base/test/test_support_ios.mm:231: NSDictionary* environment = [[NSProcessInfo
processInfo] environment];
On 2016/08/08 20:55:44, Mark Mentovai wrote:
>   return getenv("XCTestConfigurationFilePath") != nullptr;
> 
> is less wordy and faster

Done.

[rohitrao (ping after 24h), 2016-08-09 11:40:31]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 11:40:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 12:36:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 12:37:00]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-08-09 15:34:41]

LGTM

[rohitrao (ping after 24h), 2016-08-09 16:22:15]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-08-09 16:22:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2226623003/#ps20001
(title: "Review.")

[commit-bot: I haz the power, 2016-08-09 16:22:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 16:27:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 16:38:55]

Description was changed from

==========
Adds support for running unittests using XCTest on iOS.

Modifies the base TestSuite to check if running under XCTest and return early
without running tests if so.  This allows XCTest to drive running the individual
tests, while still allowing the TestSuite to perform setup tasks.

BUG=635509
==========

to

==========
Adds support for running unittests using XCTest on iOS.

Modifies the base TestSuite to check if running under XCTest and return early
without running tests if so.  This allows XCTest to drive running the individual
tests, while still allowing the TestSuite to perform setup tasks.

BUG=635509

Committed: https://crrev.com/fc9315e90cf523b90010145980f953f86c077a51
Cr-Commit-Position: refs/heads/master@{#410698}
==========

[commit-bot: I haz the power, 2016-08-09 16:38:56]

Patchset 2 (id:??) landed as
https://crrev.com/fc9315e90cf523b90010145980f953f86c077a51
Cr-Commit-Position: refs/heads/master@{#410698}

[Olivier, 2016-08-10 12:49:03]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2231813002/ by olivierrobin@chromium.org.

The reason for reverting is: frezes unittests on ios bots..

[rohitrao (ping after 24h), 2016-08-10 13:07:19]

Promise fulfilled already!  Sooner than I expected!

Our upcoming infrastructure injects xctest into every app that runs on the bots,
so my call to getenv() was always returning true.  I'll need to come up with a
better way to put the tests into "xctest mode."