Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: chrome/browser/resources/settings/site_settings/add_site_dialog.js

Issue 2226613003: MD Settings Desktop: Set embedder when adding exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'add-site-dialog' provides a dialog to add exceptions for a given Content 7 * 'add-site-dialog' provides a dialog to add exceptions for a given Content
8 * Settings category. 8 * Settings category.
9 */ 9 */
10 Polymer({ 10 Polymer({
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 /** 54 /**
55 * The tap handler for the Add [Site] button (adds the pattern and closes 55 * The tap handler for the Add [Site] button (adds the pattern and closes
56 * the dialog). 56 * the dialog).
57 * @private 57 * @private
58 */ 58 */
59 onSubmit_: function() { 59 onSubmit_: function() {
60 if (this.$.add.disabled) 60 if (this.$.add.disabled)
61 return; // Can happen when Enter is pressed. 61 return; // Can happen when Enter is pressed.
62 var pattern = this.addPatternWildcard_(this.site_); 62 var pattern = this.addPatternWildcard_(this.site_);
63 this.setCategoryPermissionForOrigin( 63 this.setCategoryPermissionForOrigin(
64 pattern, '', this.category, this.allowException ? 64 pattern, pattern, this.category, this.allowException ?
65 settings.PermissionValues.ALLOW : settings.PermissionValues.BLOCK); 65 settings.PermissionValues.ALLOW : settings.PermissionValues.BLOCK);
dschuyler 2016/08/08 18:21:26 IIUC, this is saying that we want this specific pa
Finnur 2016/08/09 11:19:54 Yeah, that's correct. Using '' (as I was doing)
66 this.$.dialog.close(); 66 this.$.dialog.close();
67 }, 67 },
68 }); 68 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698