MD Settings Desktop: Set embedder when adding exceptions.

MD Settings Desktop: Set embedder when adding exceptions.

BUG=626628
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/82e5d1649102d7bc18c98d3330396c5821eeea25
Cr-Commit-Position: refs/heads/master@{#410632}

[Finnur, 2016-08-08 15:03:52]

Description was changed from

==========
MD Settings Desktop: Set embedder when adding exceptions.

BUG=626628
==========

to

==========
MD Settings Desktop: Set embedder when adding exceptions.

BUG=626628
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-08-08 15:03:56]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 15:04:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-08-08 15:04:32]

finnur@chromium.org changed reviewers:
+ dschuyler@chromium.org

[commit-bot: I haz the power, 2016-08-08 15:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 15:57:05]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-08-08 18:21:26]

LGTM with question.

https://codereview.chromium.org/2226613003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/add_site_dialog.js (right):

https://codereview.chromium.org/2226613003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/add_site_dialog.js:65:
settings.PermissionValues.ALLOW : settings.PermissionValues.BLOCK);
IIUC, this is saying that we want this specific
pattern (by using same pattern in both pattern
args). If that is correct, then LGTM. If I'm 
not right, please tell me more about it
and I'll review it again.

[Finnur, 2016-08-09 11:19:54]

https://codereview.chromium.org/2226613003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/add_site_dialog.js (right):

https://codereview.chromium.org/2226613003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/add_site_dialog.js:65:
settings.PermissionValues.ALLOW : settings.PermissionValues.BLOCK);
Yeah, that's correct. 

Using '' (as I was doing) is equivalent to wildcard, which causes the 'Embedded
on *' message to appear.

In the old content settings system, if you add [*.]google.com, that pattern gets
used in both places, so this matches that.

[Finnur, 2016-08-09 11:20:06]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2016-08-09 11:20:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 11:29:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-09 11:30:33]

Description was changed from

==========
MD Settings Desktop: Set embedder when adding exceptions.

BUG=626628
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings Desktop: Set embedder when adding exceptions.

BUG=626628
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/82e5d1649102d7bc18c98d3330396c5821eeea25
Cr-Commit-Position: refs/heads/master@{#410632}
==========

[commit-bot: I haz the power, 2016-08-09 11:30:34]

Patchset 1 (id:??) landed as
https://crrev.com/82e5d1649102d7bc18c98d3330396c5821eeea25
Cr-Commit-Position: refs/heads/master@{#410632}