Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 22266009: Move i18n's number-format C++ code to runtime (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -533 lines) Patch
M src/extensions/i18n/i18n-extension.cc View 2 chunks +0 lines, -10 lines 0 comments Download
D src/extensions/i18n/number-format.h View 1 chunk +0 lines, -69 lines 0 comments Download
D src/extensions/i18n/number-format.cc View 1 chunk +0 lines, -418 lines 0 comments Download
M src/extensions/i18n/number-format.js View 4 chunks +5 lines, -11 lines 0 comments Download
M src/i18n.h View 3 chunks +26 lines, -0 lines 0 comments Download
M src/i18n.cc View 6 chunks +375 lines, -23 lines 0 comments Download
M src/runtime.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime.cc View 3 chunks +121 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-07 10:36:01 UTC) #1
dcarney
lgtm
7 years, 4 months ago (2013-08-07 10:41:35 UTC) #2
Michael Starzinger
LGTM.
7 years, 4 months ago (2013-08-07 11:32:05 UTC) #3
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-07 12:15:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698