Inline fsin/fcos. Huge speedup on Box2D.

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 3706 matching lines @@
     }
     case Token::kBIT_XOR: {
       __ xorps(left, right);
       break;
     }
     default: UNREACHABLE();
   }
 }
 
 
-LocationSummary* MathSqrtInstr::MakeLocationSummary() const {
+LocationSummary* MathUnaryInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
   const intptr_t kNumTemps = 0;
   LocationSummary* summary =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   summary->set_in(0, Location::RequiresFpuRegister());
   summary->set_out(Location::RequiresFpuRegister());
   return summary;
 }
 
 
-void MathSqrtInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
-  __ sqrtsd(locs()->out().fpu_reg(), locs()->in(0).fpu_reg());
+void MathUnaryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  if (kind() == MethodRecognizer::kMathSqrt) {

[Ivan Posva, 2013/08/05 23:32:16]

ditto

[srdjan, 2013/08/06 15:43:05]

Done.

+    __ sqrtsd(locs()->out().fpu_reg(), locs()->in(0).fpu_reg());
+    return;
+  }
+
+  if ((kind() == MethodRecognizer::kMathCos) ||
+      (kind() == MethodRecognizer::kMathSin)) {
+    __ pushq(RAX);
+    __ movsd(Address(RSP, 0), locs()->in(0).fpu_reg());
+    __ fldl(Address(RSP, 0));
+    if (kind() == MethodRecognizer::kMathSin) {
+      __ fsin();
+    } else {
+      ASSERT(kind() == MethodRecognizer::kMathCos);
+      __ fcos();
+    }
+    __ fstpl(Address(RSP, 0));
+    __ movsd(locs()->out().fpu_reg(), Address(RSP, 0));
+    __ addq(RSP, Immediate(kWordSize));
+    return;
+  }
+  UNREACHABLE();
 }
 
 
 LocationSummary* UnarySmiOpInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
   return LocationSummary::Make(kNumInputs,
                                Location::SameAsFirstInput(),
                                LocationSummary::kNoCall);
 }
 
@@ skipping 812 matching lines @@
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64