Inline fsin/fcos. Huge speedup on Box2D.

runtime/vm/intermediate_language_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 3604 matching lines @@
     }
     case Token::kBIT_XOR: {
       __ veorq(result, left, right);
       break;
     }
     default: UNREACHABLE();
   }
 }
 
 
-LocationSummary* MathSqrtInstr::MakeLocationSummary() const {
+LocationSummary* MathUnaryInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
   const intptr_t kNumTemps = 0;
   LocationSummary* summary =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   summary->set_in(0, Location::RequiresFpuRegister());
   summary->set_out(Location::RequiresFpuRegister());
   return summary;
 }
 
 
-void MathSqrtInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+void MathUnaryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  ASSERT(kind() == MethodRecognizer::kMathSqrt);

[Ivan Posva, 2013/08/05 23:32:16]

How about:
if (kind() == MethodRecognizer::kMathSqrt) {
 ...
} else {
  UNIMPLEMENTED();
}

[srdjan, 2013/08/06 15:43:05]

Done.

   DRegister val = EvenDRegisterOf(locs()->in(0).fpu_reg());
   DRegister result = EvenDRegisterOf(locs()->out().fpu_reg());
   __ vsqrtd(result, val);
 }
 
 
 LocationSummary* MathMinMaxInstr::MakeLocationSummary() const {
   if (result_cid() == kDoubleCid) {
     const intptr_t kNumInputs = 2;
     const intptr_t kNumTemps = 1;
@@ skipping 768 matching lines @@
   compiler->GenerateCall(token_pos(),
                          &label,
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM