Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2226563002: SkLiteDL, very nearly the rest (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkLiteDL, very nearly the rest fix saveLayer bounds all the misc calls a bit of refactoring just drawVertices and drawPatch to go, plus some todos and likely bug fixes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2226563002 Committed: https://skia.googlesource.com/skia/+/29de8d938da91a8bc02e73568979a209f116f79e

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : lattice #

Patch Set 4 : text on path #

Patch Set 5 : rsxform text #

Patch Set 6 : INFINITY for MSVC #

Patch Set 7 : give it another quack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -27 lines) Patch
M src/core/SkLiteDL.h View 1 2 3 4 3 chunks +11 lines, -12 lines 0 comments Download
M src/core/SkLiteDL.cpp View 1 2 3 4 5 6 12 chunks +218 lines, -14 lines 0 comments Download
M src/core/SkLiteRecorder.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
mtklein_C
more
4 years, 4 months ago (2016-08-07 14:57:04 UTC) #2
mtklein_C
lattice
4 years, 4 months ago (2016-08-07 15:10:38 UTC) #3
mtklein
lgtm
4 years, 4 months ago (2016-08-07 15:29:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226563002/80001
4 years, 4 months ago (2016-08-07 15:29:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/10568)
4 years, 4 months ago (2016-08-07 15:37:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226563002/100001
4 years, 4 months ago (2016-08-07 15:49:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/10413) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, ...
4 years, 4 months ago (2016-08-07 15:52:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226563002/120001
4 years, 4 months ago (2016-08-07 18:08:08 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-07 18:35:13 UTC) #20
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/29de8d938da91a8bc02e73568979a209f116f79e

Powered by Google App Engine
This is Rietveld 408576698