Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 222653003: Oilpan: Fix isAlive dispatching for GarbageCollectedMixins. (Closed)

Created:
6 years, 8 months ago by Mads Ager (chromium)
Modified:
6 years, 8 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Visibility:
Public.

Description

Oilpan: Fix isAlive dispatching for GarbageCollectedMixins. Update the test so that adjustment is needed and use a weak hash set of mixin pointers. I realized this didn't work when I needed to use it for the Node hierarchy. R=erik.corry@gmail.com, kouhei@chromium.org, oilpan-reviews@chromium.org, vegorov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170688

Patch Set 1 #

Patch Set 2 : Fix * placement #

Total comments: 1

Patch Set 3 : Add comment to virtual method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M Source/heap/HeapTest.cpp View 1 2 3 chunks +17 lines, -6 lines 0 comments Download
M Source/heap/Visitor.h View 1 4 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mads Ager (chromium)
6 years, 8 months ago (2014-04-02 18:08:54 UTC) #1
Mads Ager (chromium)
https://codereview.chromium.org/222653003/diff/20001/Source/heap/HeapTest.cpp File Source/heap/HeapTest.cpp (right): https://codereview.chromium.org/222653003/diff/20001/Source/heap/HeapTest.cpp#newcode178 Source/heap/HeapTest.cpp:178: virtual void virtualMethod() { } I'll add a comment ...
6 years, 8 months ago (2014-04-02 18:13:55 UTC) #2
Erik Corry
lgtm
6 years, 8 months ago (2014-04-02 18:21:13 UTC) #3
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 8 months ago (2014-04-02 18:30:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/222653003/40001
6 years, 8 months ago (2014-04-02 18:31:10 UTC) #5
commit-bot: I haz the power
Change committed as 170688
6 years, 8 months ago (2014-04-02 19:41:39 UTC) #6
haraken
6 years, 8 months ago (2014-04-03 04:01:10 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698